hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 17:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Fix bad magic optimization in NonAssignedFields.ql

Browse Source
This commit is contained in:
Tom Hvitved
2020-01-16 12:31:14 +01:00
parent f7278d36e1
commit f4c255cb62
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
csharp/ql/src/Dead Code/NonAssignedFields.ql
View File

@@ -34,15 +34,14 @@ ValueOrRefType getAReferencedType(Type t) {
predicate isTypeExternallyInitialized(ValueOrRefType t) {
// The type got created via a call to PtrToStructure().
exists(MethodCall mc |
exists(MethodCall mc, Type t0, Expr arg |
mc.getTarget() = any(SystemRuntimeInteropServicesMarshalClass c).getPtrToStructureTypeMethod() and
t = getAReferencedType(mc.getArgument(1).(TypeofExpr).getTypeAccess().getTarget())
)
or
// The type got created via a call to PtrToStructure().
exists(MethodCall mc |
mc.getTarget() = any(SystemRuntimeInteropServicesMarshalClass c).getPtrToStructureObjectMethod() and
t = getAReferencedType(mc.getArgument(1).getType())
t = getAReferencedType(t0) and
arg = mc.getArgument(1)
|
t0 = arg.(TypeofExpr).getTypeAccess().getTarget()
or
t0 = arg.getType()
)
or
// An extern method exists which could initialize the type.