hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-06-06 05:57:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix range loop CFG

Browse Source
This commit is contained in:
Owen Mansel-Chan
2026-05-30 06:47:59 +01:00
parent d8ac19e8c2
commit ee6b8394ab
1 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
go/ql/lib/semmle/go/controlflow/ControlFlowGraphShared.qll
View File

@@ -859,6 +859,10 @@ module GoCfg {
notBlankIdent(assgn.(Go::Assignment).getLhs(j))
or
notBlankIdent(assgn.(Go::ValueSpec).getNameExpr(j))
or
notBlankIdent(assgn.(Go::RangeStmt).getKey()) and j = 0
or
notBlankIdent(assgn.(Go::RangeStmt).getValue()) and j = 1
) and
result = "assign:" + j.toString() and
ord = 2 * j + 1
@@ -1207,21 +1211,22 @@ module GoCfg {
or
n1.isAfter(s.getDomain()) and n2.isAdditional(s, "[LoopHeader]")
or
n1.isAdditional(s, "[LoopHeader]") and
n1.isAdditional(s, "[LoopHeader]") and n2.isAdditional(s, "next")
or
n1.isAdditional(s, "next") and
(
n2.isBefore(s.getKey())
exists(getFirstEpilogueTag(s)) and n2.isAdditional(s, getFirstEpilogueTag(s))
or
not exists(s.getKey()) and n2.isBefore(s.getBody())
not exists(getFirstEpilogueTag(s)) and n2.isBefore(s.getBody())
)
or
n1.isAfter(s.getKey()) and
(
n2.isBefore(s.getValue())
or
not exists(s.getValue()) and n2.isBefore(s.getBody())
exists(string tag1, string tag2 |
epilogueSucc(s, tag1, tag2) and
n1.isAdditional(s, tag1) and
n2.isAdditional(s, tag2)
)
or
n1.isAfter(s.getValue()) and n2.isBefore(s.getBody())
n1.isAdditional(s, getLastEpilogueTag(s)) and n2.isBefore(s.getBody())
or
n1.isAfter(s.getBody()) and n2.isAdditional(s, "[LoopHeader]")
or