hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Data flow: Avoid bad join-order in pathIntoCallable0

Browse Source
This commit is contained in:
Tom Hvitved
2021-10-13 20:07:10 +02:00
parent 878203f1d0
commit ee44e742f6
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl.qll
View File

@@ -3561,13 +3561,10 @@ private predicate parameterCand(
pragma[nomagic]
private predicate pathIntoCallable0(
PathNodeMid mid, DataFlowCallable callable, int i, CallContext outercc, DataFlowCall call,
AccessPath ap
AccessPath ap, AccessPathApprox apa
) {
exists(AccessPathApprox apa |
pathIntoArg(mid, i, outercc, call, ap, apa) and
callable = resolveCall(call, outercc) and
parameterCand(callable, any(int j | j <= i and j >= i), apa, mid.getConfiguration())
)
pathIntoArg(mid, i, outercc, call, ap, apa) and
callable = resolveCall(call, outercc)
}
/**
@@ -3579,8 +3576,9 @@ private predicate pathIntoCallable(
PathNodeMid mid, ParamNodeEx p, CallContext outercc, CallContextCall innercc, SummaryCtx sc,
DataFlowCall call
) {
exists(int i, DataFlowCallable callable, AccessPath ap |
pathIntoCallable0(mid, callable, i, outercc, call, ap) and
exists(int i, DataFlowCallable callable, AccessPath ap, AccessPathApprox apa |
pathIntoCallable0(mid, callable, i, outercc, call, ap, apa) and
parameterCand(callable, i, apa, mid.getConfiguration()) and
p.isParameterOf(callable, i) and
(
sc = TSummaryCtxSome(p, ap)