hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-20 00:43:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Arthur Baars <aibaars@github.com>
This commit is contained in:
Tom Hvitved
2020-12-14 14:53:35 +01:00
committed by GitHub
parent 89fb2f8498
commit ec4ead2117
1 changed files with 7 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
ql/src/codeql_ruby/controlflow/internal/ControlFlowGraphImpl.qll
View File

@@ -377,12 +377,9 @@ module Trees {
private class ClassTree extends RescueEnsureBlockTree, Class {
final override AstNode getChildNode(int i, boolean rescuable) {
rescuable = true and
(
result = this.getName() and i = 0
or
result = this.getChild(i - 1)
)
result = this.getName() and i = 0 and rescuable = false
or
result = this.getChild(i - 1) and rescuable = true
}
}
@@ -824,12 +821,9 @@ module Trees {
private class ModuleTree extends RescueEnsureBlockTree, Module {
final override AstNode getChildNode(int i, boolean rescuable) {
rescuable = true and
(
result = this.getName() and i = 0
or
result = this.getChild(i - 1)
)
result = this.getName() and i = 0 and rescuable = false
or
result = this.getChild(i - 1) and rescuable = true
}
}
@@ -1229,7 +1223,7 @@ module Trees {
final override AstNode getChildNode(int i, boolean rescuable) {
result = this.getObject() and
i = 0 and
rescuable = true // TODO: CHECK THIS
rescuable = false
or
result = this.getParameters() and
i = 1 and