hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-24 16:25:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: Improve constant-loop-condition

Browse Source
This commit is contained in:
Marcono1234
2021-03-04 23:33:29 +01:00
parent d685aff5e2
commit e9e9634306
3 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
java/ql/src/Likely Bugs/Termination/ConstantLoopCondition.ql
View File

@@ -79,7 +79,11 @@ where
) and
// And `cond` does not use method calls, field reads, or array reads.
not exists(MethodAccess ma | ma.getParent*() = cond) and
not exists(FieldRead fa | fa.getParent*() = cond) and
not exists(FieldRead fa |
// Ignore if field is final
not fa.getField().isFinal() and
fa.getParent*() = cond
) and
not exists(ArrayAccess aa | aa.getParent*() = cond)
select cond, "$@ might not terminate, as this loop condition is constant within the loop.", loop,
"Loop"

6
java/ql/test/query-tests/ConstantLoopCondition/A.java
View File

@@ -1,4 +1,6 @@
class A {
final boolean cond = otherCond();
boolean otherCond() { return 3 > 5; }
void f(int initx) {
@@ -30,5 +32,9 @@ class A {
while(initx > 0) { // OK: loop used as an if-statement
break;
}
while (cond) { // BAD: read of final field
i++;
}
}
}

7
java/ql/test/query-tests/ConstantLoopCondition/ConstantLoopCondition.expected
View File

@@ -1,3 +1,4 @@
| A.java:6:11:6:15 | !... | $@ might not terminate, as this loop condition is constant within the loop. | A.java:6:5:6:16 | stmt | Loop |
| A.java:13:11:13:15 | ... > ... | $@ might not terminate, as this loop condition is constant within the loop. | A.java:12:5:12:19 | stmt | Loop |
| A.java:27:20:27:32 | ... < ... | $@ might not terminate, as this loop condition is constant within the loop. | A.java:27:5:27:38 | stmt | Loop |
| A.java:8:11:8:15 | !... | $@ might not terminate, as this loop condition is constant within the loop. | A.java:8:5:8:16 | stmt | Loop |
| A.java:15:11:15:15 | ... > ... | $@ might not terminate, as this loop condition is constant within the loop. | A.java:14:5:14:19 | stmt | Loop |
| A.java:29:20:29:32 | ... < ... | $@ might not terminate, as this loop condition is constant within the loop. | A.java:29:5:29:38 | stmt | Loop |
| A.java:36:12:36:15 | cond | $@ might not terminate, as this loop condition is constant within the loop. | A.java:36:5:36:16 | stmt | Loop |