hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-03 04:39:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

implement review suggestions

Browse Source
This commit is contained in:
Paolo Tranquilli
2021-11-23 12:27:57 +00:00
committed by GitHub
parent 8b44d5c39e
commit e99a040884
5 changed files with 20 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
cpp/ql/lib/semmle/code/cpp/ir/implementation/aliased_ssa/Operand.qll
View File

@@ -416,9 +416,10 @@ class ThisArgumentOperand extends ArgumentOperand {
// in most cases the def location makes more sense, but in some corner cases it
// does not have a location: in those cases we fall back to the use location
override Language::Location getLocation() {
if exists(Language::Location loc | loc = this.getAnyDef().getLocation())
then result = this.getAnyDef().getLocation()
else result = this.getUse().getLocation()
result = this.getAnyDef().getLocation()
or
not exists(this.getAnyDef().getLocation()) and
result = this.getUse().getLocation()
}
}

7
cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/Operand.qll
View File

@@ -416,9 +416,10 @@ class ThisArgumentOperand extends ArgumentOperand {
// in most cases the def location makes more sense, but in some corner cases it
// does not have a location: in those cases we fall back to the use location
override Language::Location getLocation() {
if exists(Language::Location loc | loc = this.getAnyDef().getLocation())
then result = this.getAnyDef().getLocation()
else result = this.getUse().getLocation()
result = this.getAnyDef().getLocation()
or
not exists(this.getAnyDef().getLocation()) and
result = this.getUse().getLocation()
}
}

7
cpp/ql/lib/semmle/code/cpp/ir/implementation/unaliased_ssa/Operand.qll
View File

@@ -416,9 +416,10 @@ class ThisArgumentOperand extends ArgumentOperand {
// in most cases the def location makes more sense, but in some corner cases it
// does not have a location: in those cases we fall back to the use location
override Language::Location getLocation() {
if exists(Language::Location loc | loc = this.getAnyDef().getLocation())
then result = this.getAnyDef().getLocation()
else result = this.getUse().getLocation()
result = this.getAnyDef().getLocation()
or
not exists(this.getAnyDef().getLocation()) and
result = this.getUse().getLocation()
}
}

7
csharp/ql/src/experimental/ir/implementation/raw/Operand.qll
View File

@@ -416,9 +416,10 @@ class ThisArgumentOperand extends ArgumentOperand {
// in most cases the def location makes more sense, but in some corner cases it
// does not have a location: in those cases we fall back to the use location
override Language::Location getLocation() {
if exists(Language::Location loc | loc = this.getAnyDef().getLocation())
then result = this.getAnyDef().getLocation()
else result = this.getUse().getLocation()
result = this.getAnyDef().getLocation()
or
not exists(this.getAnyDef().getLocation()) and
result = this.getUse().getLocation()
}
}

7
csharp/ql/src/experimental/ir/implementation/unaliased_ssa/Operand.qll
View File

@@ -416,9 +416,10 @@ class ThisArgumentOperand extends ArgumentOperand {
// in most cases the def location makes more sense, but in some corner cases it
// does not have a location: in those cases we fall back to the use location
override Language::Location getLocation() {
if exists(Language::Location loc | loc = this.getAnyDef().getLocation())
then result = this.getAnyDef().getLocation()
else result = this.getUse().getLocation()
result = this.getAnyDef().getLocation()
or
not exists(this.getAnyDef().getLocation()) and
result = this.getUse().getLocation()
}
}