hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-21 23:14:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

Simplify ensureCorrectTypeInfo

Browse Source
This commit is contained in:
Chris Smowton
2024-10-23 21:58:52 +01:00
committed by Owen Mansel-Chan
parent e46ec5a171
commit e90e313295
1 changed files with 5 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
go/ql/lib/semmle/go/dataflow/internal/FlowSummaryImpl.qll
View File

@@ -276,42 +276,23 @@ module SourceSinkInterpretationInput implements
or
exists(DataFlow::Write fw | fw.writesField(recv, sse.asEntity(), _))
) and
exists(string pkg, string typename, boolean subtypes, Type syntacticRecvBaseType |
exists(string pkg, string typename, boolean subtypes, Type syntacticRecvBaseType, Type targetType |
sse.hasTypeInfo(pkg, typename, subtypes) and
targetType.hasQualifiedName(pkg, typename) and
syntacticRecvBaseType = lookThroughPointerType(getSyntacticRecv(recv).getType())
|
subtypes = [true, false] and
syntacticRecvBaseType.hasQualifiedName(pkg, typename)
syntacticRecvBaseType = targetType
or
subtypes = true and
(
// `syntacticRecvBaseType`'s underlying type might be an interface type and `sse`
// might be a method defined on an interface which is a subtype of it.
exists(Type t |
t = syntacticRecvBaseType.getUnderlyingType().(InterfaceType).getAnEmbeddedInterface() and
t.hasQualifiedName(pkg, typename) and
sse.asEntity().(Method).hasQualifiedName(pkg, typename, _)
)
targetType = syntacticRecvBaseType.getUnderlyingType().(InterfaceType).getAnEmbeddedInterface()
or
// `syntacticRecvBaseType`'s underlying type might be a struct type and `sse`
// might be a promoted method or field.
exists(StructType st, Field field1, Field field2, int depth1, int depth2, Type t1, Type t2 |
st = syntacticRecvBaseType.getUnderlyingType() and
field1 = st.getFieldAtDepth(_, depth1) and
field2 = st.getFieldAtDepth(_, depth2) and
t1 = lookThroughPointerType(field1.getType()) and
t2 = lookThroughPointerType(field2.getType()) and
(
field1 = field2
or
field2 = t1.getUnderlyingType().(StructType).getFieldAtDepth(_, depth2 - depth1 - 1)
) and
matchTypeInfo(sse, t1)
|
sse.asEntity().(Method).getReceiverBaseType() = t2
or
sse.asEntity().(Field).getDeclaringType() = t2.getUnderlyingType()
)
syntacticRecvBaseType.getUnderlyingType().(StructType).hasEmbeddedField(targetType, _)
)
)
}
@@ -343,15 +324,6 @@ module SourceSinkInterpretationInput implements
.getBaseInstruction()
}
bindingset[sse, t]
pragma[inline_late]
private predicate matchTypeInfo(SourceOrSinkElement sse, Type t) {
exists(string pkg, string typename |
sse.hasTypeInfo(pkg, typename, true) and
t.hasQualifiedName(pkg, typename)
)
}
/** Provides additional sink specification logic. */
bindingset[c]
predicate interpretOutput(string c, InterpretNode mid, InterpretNode node) {