hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 12:46:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #10298 from aibaars/suppress-require

Browse Source 
Ruby: exclude 'require' and 'require_relative' definitions from call graph
This commit is contained in:
Arthur Baars
2022-09-05 20:58:38 +02:00
committed by GitHub
parent 7dc5bdafe3 b2431d0b50
commit e8d13d156d
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ruby/ql/lib/codeql/ruby/ast/internal/Module.qll
View File

@@ -137,7 +137,14 @@ private module Cached {
}
cached
Method lookupMethod(Module m, string name) { TMethod(result) = lookupMethodOrConst(m, name) }
Method lookupMethod(Module m, string name) {
// The syntax_suggest library redefines Kernel.require/require_relative.
// Somehow this causes performance issues on ruby/ruby. As a workaround
// we exclude 'require' and 'require_relative'.
// TODO: find the actual cause of the slowdown and fix things properly.
not name = ["require", "require_relative"] and
TMethod(result) = lookupMethodOrConst(m, name)
}
cached
Expr lookupConst(Module m, string name) {