hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1856 from asger-semmle/ts-base-types

Browse Source 
Approved by xiemaisi
This commit is contained in:
semmle-qlci
2019-09-03 10:12:30 +01:00
committed by GitHub
parent d092905c66 8737dbb73d
commit e4d59c361a
8 changed files with 27 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
javascript/extractor/lib/typescript/src/type_table.ts
View File

@@ -974,8 +974,10 @@ export class TypeTable {
if (superType == null) continue;
let baseTypeSymbol = superType.symbol;
if (baseTypeSymbol == null) continue;
let baseId = this.getSymbolId(baseTypeSymbol);
// Note: take care not to perform a recursive call between the two `push` calls.
this.baseTypes.symbols.push(symbolId);
this.baseTypes.baseTypeSymbols.push(this.getSymbolId(baseTypeSymbol));
this.baseTypes.baseTypeSymbols.push(baseId);
}
}
}

4
javascript/ql/src/semmle/javascript/CanonicalNames.qll
View File

@@ -210,7 +210,9 @@ class CanonicalName extends @symbol {
class TypeName extends CanonicalName {
TypeName() {
exists(TypeReference ref | type_symbol(ref, this)) or
exists(TypeDefinition def | ast_node_symbol(def, this))
exists(TypeDefinition def | ast_node_symbol(def, this)) or
base_type_names(_, this) or
base_type_names(this, _)
}
/**

3
javascript/ql/test/library-tests/TypeScript/ExternalBaseTypes/BaseTypes.expected Normal file
View File

@@ -0,0 +1,3 @@
| B in module 'mylib' | A in module 'mylib' |
| C in module 'mylib' | B in module 'mylib' |
| D in module 'mylib' | C in module 'mylib' |

5
javascript/ql/test/library-tests/TypeScript/ExternalBaseTypes/BaseTypes.ql Normal file
View File

@@ -0,0 +1,5 @@
import javascript
from TypeName tn
where tn.hasQualifiedName("mylib", _)
select tn, tn.getABaseTypeName()

4
javascript/ql/test/library-tests/TypeScript/ExternalBaseTypes/node_modules/@types/mylib/index.d.ts generated vendored Normal file
View File

@@ -0,0 +1,4 @@
export interface A {}
export interface B extends A {}
export interface C extends B {}
export interface D extends C {}

1
javascript/ql/test/library-tests/TypeScript/ExternalBaseTypes/options Normal file
View File

@@ -0,0 +1 @@
semmle-extractor-options:--exclude node_modules/**

5
javascript/ql/test/library-tests/TypeScript/ExternalBaseTypes/tsconfig.json Normal file
View File

@@ -0,0 +1,5 @@
{
"compilerOptions": {
"baseUrl": "./"
}
}

3
javascript/ql/test/library-tests/TypeScript/ExternalBaseTypes/tst.ts Normal file
View File

@@ -0,0 +1,3 @@
import { D } from "mylib";
export var foo: D = null;