hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-21 15:05:56 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix MaxIntOrMaxUint.isBoundFor

Browse Source 
It was wrong for strictnessOffset = 1 before.
This commit is contained in:
Owen Mansel-Chan
2023-12-17 06:16:33 +00:00
parent 36c4f5d1b2
commit e45e92eaa7
2 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
go/ql/lib/semmle/go/security/IncorrectIntegerConversionLib.qll
View File

@@ -15,15 +15,11 @@ abstract private class MaxIntOrMaxUint extends DeclaredConstant {
*/
predicate isBoundFor(int b, int architectureBitSize, float strictnessOffset) {
// 2.pow(x) - 1 - strictnessOffset <= 2.pow(b) - 1
exists(int x |
x = this.getOrder(architectureBitSize) and
b = validBitSize() and
(
strictnessOffset = 0 and x <= b
or
strictnessOffset = 1 and x <= b - 1
)
)
// For the values that we are restricting `b` to, `strictnessOffset` has no
// effect on the result, so we can ignore it.
b = validBitSize() and
strictnessOffset = [0, 1] and
this.getOrder(architectureBitSize) <= b
}
}

1
go/ql/test/query-tests/Security/CWE-681/IncorrectIntegerConversion.expected
View File

@@ -1,3 +1,2 @@
testFailures
| IncorrectIntegerConversion.go:497:15:497:15 | i | Unexpected result: hasValueFlow="i" |
failures