hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #31 from esben-semmle/js/fewer-alerts-for-incomplete-object-initialization

Browse Source 
JS: change alert location for js/incomplete-object-initialization
This commit is contained in:
Max Schaefer
2018-08-09 13:58:11 +01:00
committed by GitHub
parent badb167962 8ee943f264
commit e32dc08cd0
4 changed files with 24 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
change-notes/1.18/analysis-javascript.md
View File

@@ -48,6 +48,7 @@
| Uncontrolled command line | More true-positive results | This rule now recognizes indirect command injection through `sh -c` and similar. |
| Unused variable | Fewer results | This rule no longer flags class expressions that could be made anonymous. While technically true, these results are not interesting. |
| Unused variable | Renamed | This rule has been renamed to "Unused variable, import, function or class" to reflect the fact that it flags different kinds of unused program elements. |
| Use of incompletely initialized object| Fewer results | This rule now flags the constructor instead its errorneous `this` or `super` expressions. |
## Changes to QL libraries

3
javascript/ql/src/LanguageFeatures/ThisBeforeSuper.ql
View File

@@ -11,6 +11,7 @@
*/
import javascript
import semmle.javascript.RestrictedLocations
/**
* Holds if `e` is an expression of the given `kind` that must be guarded by a
@@ -59,4 +60,4 @@ where needsGuard(e, kind) and unguarded(e, ctor) and
sc.getBinder() = ctor and
sc.getEnclosingFunction() != ctor
)
select e, "The super constructor must be called before using '" + kind + "'."
select (FirstLineOf)ctor, "The super constructor must be called before using '$@'.", e, kind

26
javascript/ql/test/query-tests/LanguageFeatures/ThisBeforeSuper/ThisBeforeSuper.expected
View File

@@ -1,12 +1,14 @@
| invalid.js:5:40:5:43 | this | The super constructor must be called before using 'this'. |
| invalid.js:6:40:6:43 | this | The super constructor must be called before using 'this'. |
| invalid.js:7:40:7:46 | super.c | The super constructor must be called before using 'super'. |
| invalid.js:8:40:8:43 | this | The super constructor must be called before using 'this'. |
| invalid.js:9:40:9:43 | this | The super constructor must be called before using 'this'. |
| invalid.js:10:40:10:46 | super.c | The super constructor must be called before using 'super'. |
| invalid.js:11:46:11:49 | this | The super constructor must be called before using 'this'. |
| invalid.js:12:46:12:49 | this | The super constructor must be called before using 'this'. |
| invalid.js:13:46:13:52 | super.c | The super constructor must be called before using 'super'. |
| invalid.js:14:99:14:102 | this | The super constructor must be called before using 'this'. |
| invalid.js:15:76:15:79 | this | The super constructor must be called before using 'this'. |
| invalid.js:16:56:16:59 | this | The super constructor must be called before using 'this'. |
| invalid.js:5:35:5:52 | () { this.c = 0; } | The super constructor must be called before using '$@'. | invalid.js:5:40:5:43 | this | this |
| invalid.js:6:35:6:50 | () { this.c(); } | The super constructor must be called before using '$@'. | invalid.js:6:40:6:43 | this | this |
| invalid.js:7:35:7:51 | () { super.c(); } | The super constructor must be called before using '$@'. | invalid.js:7:40:7:46 | super.c | super |
| invalid.js:8:35:8:61 | () { th ... er(); } | The super constructor must be called before using '$@'. | invalid.js:8:40:8:43 | this | this |
| invalid.js:9:35:9:59 | () { th ... er(); } | The super constructor must be called before using '$@'. | invalid.js:9:40:9:43 | this | this |
| invalid.js:10:35:10:60 | () { su ... er(); } | The super constructor must be called before using '$@'. | invalid.js:10:40:10:46 | super.c | super |
| invalid.js:11:35:11:55 | () { su ... s.c); } | The super constructor must be called before using '$@'. | invalid.js:11:46:11:49 | this | this |
| invalid.js:12:35:12:57 | () { su ... c()); } | The super constructor must be called before using '$@'. | invalid.js:12:46:12:49 | this | this |
| invalid.js:13:35:13:58 | () { su ... c()); } | The super constructor must be called before using '$@'. | invalid.js:13:46:13:52 | super.c | super |
| invalid.js:14:35:14:118 | () { cl ... er(); } | The super constructor must be called before using '$@'. | invalid.js:14:99:14:102 | this | this |
| invalid.js:15:71:15:95 | () { th ... er(); } | The super constructor must be called before using '$@'. | invalid.js:15:76:15:79 | this | this |
| invalid.js:16:35:16:66 | () { if ... .a(); } | The super constructor must be called before using '$@'. | invalid.js:16:56:16:59 | this | this |
| invalid.js:26:16:26:19 | () {\\n ... ;\\n } | The super constructor must be called before using '$@'. | invalid.js:27:9:27:12 | this | this |
| invalid.js:26:16:26:19 | () {\\n ... ;\\n } | The super constructor must be called before using '$@'. | invalid.js:28:9:28:12 | this | this |

7
javascript/ql/test/query-tests/LanguageFeatures/ThisBeforeSuper/invalid.js
View File

@@ -21,3 +21,10 @@ class A41 extends B1 { constructor() { if (a) super(); this.a(); } }
class B2 { constructor() { throw ""; } }
class A42 extends B2 { constructor() { try { super(); } finally { this.a; } } }
class A43 extends B2 { constructor() { try { super(); } catch (err) { } this.a; } }
class A44 extends B1 {
constructor() {
this.p1 = 0;
this.p2 = 0;
}
}