hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-24 16:25:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #14119 from github/alexdenisov/sequence-expr

Browse Source 
Swift: fix SequenceExpr extraction
This commit is contained in:
AlexDenisov
2023-09-04 12:29:07 +02:00
committed by GitHub
parent 7d89028688 888dd786b4
commit e2602fbbc4
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
swift/extractor/translators/ExprTranslator.cpp
View File

@@ -460,7 +460,17 @@ codeql::UnresolvedMemberExpr ExprTranslator::translateUnresolvedMemberExpr(
codeql::SequenceExpr ExprTranslator::translateSequenceExpr(const swift::SequenceExpr& expr) {
auto entry = createExprEntry(expr);
entry.elements = dispatcher.fetchRepeatedLabels(expr.getElements());
// SequenceExpr represents a flat tree of expressions with elements at odd indices being the
// parents of the elements with even indices, so we only extract the "parent" elements here. In
// case there is a single child, we extract it as a parent. See
// https://github.com/github/codeql/pull/14119 and commit message for more details.
if (expr.getNumElements() == 1) {
entry.elements = dispatcher.fetchRepeatedLabels(expr.getElements());
} else {
for (int i = 1; i < expr.getNumElements(); i += 2) {
entry.elements.emplace_back(dispatcher.fetchLabel(expr.getElement(i)));
}
}
return entry;
}