hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-19 14:04:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

Rust: Add variants with pattern matching for unreachable_let_1 and 2.

Browse Source
This commit is contained in:
Geoffrey White
2024-10-17 15:38:03 +01:00
parent 3d0c86e176
commit e1aaa136b2
2 changed files with 13 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
rust/ql/test/query-tests/unusedentities/UnreachableCode.expected
View File

@@ -13,6 +13,7 @@
| unreachable.rs:169:4:169:18 | ExprStmt | This code is never reached. |
| unreachable.rs:177:4:177:18 | ExprStmt | This code is never reached. |
| unreachable.rs:180:2:180:16 | ExprStmt | This code is never reached. |
| unreachable.rs:197:2:197:16 | ExprStmt | This code is never reached. |
| unreachable.rs:203:3:203:17 | ExprStmt | This code is never reached. |
| unreachable.rs:206:2:206:16 | ExprStmt | This code is never reached. |
| unreachable.rs:218:3:218:17 | ExprStmt | This code is never reached. |

24
rust/ql/test/query-tests/unusedentities/unreachable.rs
View File

@@ -187,14 +187,14 @@ fn unreachable_paren() {
}
fn unreachable_let_1() {
if let Some(a) = maybe_get_a_number() {
do_something();
return;
} else {
do_something();
}
do_something(); // SPURIOUS: unreachable code
if let a = get_a_number() { // (always succeeds)
do_something();
@@ -207,12 +207,12 @@ fn unreachable_let_1() {
}
fn unreachable_let_2() {
let Some(a) = maybe_get_a_number() else {
do_something();
return;
};
do_something();
let a = maybe_get_a_number() else { // (always succeeds)
do_something(); // BAD: unreachable code