hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-03 12:45:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

Put space after MISSING: and SPURIOUS:

Browse Source 
This is the preferred style now
This commit is contained in:
Owen Mansel-Chan
2021-10-20 09:41:16 +01:00
parent f38fd5722f
commit e01291f880
5 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
ql/test/library-tests/semmle/go/concepts/LoggerCall/glog.go
View File

@@ -10,44 +10,44 @@ import (
func glogTest() {
glog.Error(text) // $ logger=text
glog.ErrorDepth(0, text) // $ MISSING:logger=text
glog.ErrorDepth(0, text) // $ MISSING: logger=text
glog.Errorf(fmt, text) // $ logger=fmt logger=text
glog.Errorln(text) // $ logger=text
glog.Exit(text) // $ logger=text
glog.ExitDepth(0, text) // $ MISSING:logger=text
glog.ExitDepth(0, text) // $ MISSING: logger=text
glog.Exitf(fmt, text) // $ logger=fmt logger=text
glog.Exitln(text) // $ logger=text
glog.Fatal(text) // $ logger=text
glog.FatalDepth(0, text) // $ MISSING:logger=text
glog.FatalDepth(0, text) // $ MISSING: logger=text
glog.Fatalf(fmt, text) // $ logger=fmt logger=text
glog.Fatalln(text) // $ logger=text
glog.Info(text) // $ logger=text
glog.InfoDepth(0, text) // $ MISSING:logger=text
glog.InfoDepth(0, text) // $ MISSING: logger=text
glog.Infof(fmt, text) // $ logger=fmt logger=text
glog.Infoln(text) // $ logger=text
glog.Warning(text) // $ logger=text
glog.WarningDepth(0, text) // $ MISSING:logger=text
glog.WarningDepth(0, text) // $ MISSING: logger=text
glog.Warningf(fmt, text) // $ logger=fmt logger=text
glog.Warningln(text) // $ logger=text
klog.Error(text) // $ logger=text
klog.ErrorDepth(0, text) // $ MISSING:logger=text
klog.ErrorDepth(0, text) // $ MISSING: logger=text
klog.Errorf(fmt, text) // $ logger=fmt logger=text
klog.Errorln(text) // $ logger=text
klog.Exit(text) // $ logger=text
klog.ExitDepth(0, text) // $ MISSING:logger=text
klog.ExitDepth(0, text) // $ MISSING: logger=text
klog.Exitf(fmt, text) // $ logger=fmt logger=text
klog.Exitln(text) // $ logger=text
klog.Fatal(text) // $ logger=text
klog.FatalDepth(0, text) // $ MISSING:logger=text
klog.FatalDepth(0, text) // $ MISSING: logger=text
klog.Fatalf(fmt, text) // $ logger=fmt logger=text
klog.Fatalln(text) // $ logger=text
klog.Info(text) // $ logger=text
klog.InfoDepth(0, text) // $ MISSING:logger=text
klog.InfoDepth(0, text) // $ MISSING: logger=text
klog.Infof(fmt, text) // $ logger=fmt logger=text
klog.Infoln(text) // $ logger=text
klog.Warning(text) // $ logger=text
klog.WarningDepth(0, text) // $ MISSING:logger=text
klog.WarningDepth(0, text) // $ MISSING: logger=text
klog.Warningf(fmt, text) // $ logger=fmt logger=text
klog.Warningln(text) // $ logger=text
}

2
ql/test/library-tests/semmle/go/dataflow/GuardingFunctions/test.go
View File

@@ -842,7 +842,7 @@ func test() {
s := source()
isValid := !guardBool(s)
if isValid {
sink(s) // $ SPURIOUS:dataflow=s
sink(s) // $ SPURIOUS: dataflow=s
} else {
sink(s) // $ dataflow=s
}

6
ql/test/library-tests/semmle/go/dataflow/PromotedMethods/methods.go
View File

@@ -23,7 +23,7 @@ func (e Embedded) sinkFieldOnEmbeddedNonPointerReceiver() {
}
func (e *Embedded) sinkFieldOnEmbeddedPointerReceiver() {
sink(e.field) // $ MISSING:promotedmethods=nonPointerSender1 promotedmethods=pointerSender1 promotedmethods=nonPointerSender2 promotedmethods=pointerSender2
sink(e.field) // $ MISSING: promotedmethods=nonPointerSender1 promotedmethods=pointerSender1 promotedmethods=nonPointerSender2 promotedmethods=pointerSender2
}
func (base1 Base1) sinkFieldOnBase1NonPointerReceiver() {
@@ -31,7 +31,7 @@ func (base1 Base1) sinkFieldOnBase1NonPointerReceiver() {
}
func (base1 *Base1) sinkFieldOnBase1PointerReceiver() {
sink(base1.field) // $ promotedmethods=pointerSender1 MISSING:promotedmethods=nonPointerSender1
sink(base1.field) // $ promotedmethods=pointerSender1 MISSING: promotedmethods=nonPointerSender1
}
func (base2 Base2) sinkFieldOnBase2NonPointerReceiver() {
@@ -39,7 +39,7 @@ func (base2 Base2) sinkFieldOnBase2NonPointerReceiver() {
}
func (base2 *Base2) sinkFieldOnBase2PointerReceiver() {
sink(base2.field) // $ promotedmethods=pointerSender2 MISSING:promotedmethods=nonPointerSender2
sink(base2.field) // $ promotedmethods=pointerSender2 MISSING: promotedmethods=nonPointerSender2
}
func nonPointerSender1() {

12
ql/test/library-tests/semmle/go/frameworks/SQL/main.go
View File

@@ -59,16 +59,16 @@ func test2(tx *sql.Tx, query string, ctx context.Context) {
}
func test3(db *sql.DB, ctx context.Context) {
stmt1, _ := db.Prepare(query21) // $ SPURIOUS:querystring=query21
stmt1.Exec() // $ MISSING:query=query21
stmt2, _ := db.PrepareContext(ctx, query22) // $ SPURIOUS:querystring=query22
stmt2.ExecContext(ctx) // $ MISSING:query=query22
stmt3, _ := db.Prepare(query23) // $ SPURIOUS:querystring=query23
stmt1, _ := db.Prepare(query21) // $ SPURIOUS: querystring=query21
stmt1.Exec() // $ MISSING: query=query21
stmt2, _ := db.PrepareContext(ctx, query22) // $ SPURIOUS: querystring=query22
stmt2.ExecContext(ctx) // $ MISSING: query=query22
stmt3, _ := db.Prepare(query23) // $ SPURIOUS: querystring=query23
runQuery(stmt3)
}
func runQuery(stmt *sql.Stmt) {
stmt.Exec() // $ MISSING:query=query23
stmt.Exec() // $ MISSING: query=query23
}
func main() {}

8
ql/test/library-tests/semmle/go/frameworks/Zap/test.go
View File

@@ -61,7 +61,7 @@ func testZapLoggerWarn(logger *zap.Logger) {
func testZapLoggerNop() {
// We do not currently recognise that a logger made using NewNop() does not actually do any logging
logger := zap.NewNop()
logger.Debug(getUntrustedString()) // $ SPURIOUS:zap="call to getUntrustedString"
logger.Debug(getUntrustedString()) // $ SPURIOUS: zap="call to getUntrustedString"
}
func testLoggerNamed(logger *zap.Logger) {
@@ -74,7 +74,7 @@ func testLoggerWith(logger *zap.Logger) *zap.Logger {
logger1.Info("hello world")
logger2 := logger.With(zap.String("key", getUntrustedString())) // $ zap="call to String"
logger2.Info("hello world")
logger3 := logger.With(zap.String("key", getUntrustedString())) // $ SPURIOUS:zap="call to String"
logger3 := logger.With(zap.String("key", getUntrustedString())) // $ SPURIOUS: zap="call to String"
return logger3
}
@@ -83,7 +83,7 @@ func getLoggerWithUntrustedField() *zap.Logger {
}
func getLoggerWithUntrustedFieldUnused() *zap.Logger {
return zap.NewExample().With(zap.NamedError("key", getUntrustedData().(error))) // $ SPURIOUS:zap="call to NamedError"
return zap.NewExample().With(zap.NamedError("key", getUntrustedData().(error))) // $ SPURIOUS: zap="call to NamedError"
}
func testLoggerWithAcrossFunctionBoundary() {
@@ -95,7 +95,7 @@ func testLoggerWithOptions(logger *zap.Logger) *zap.Logger {
logger1.Info("hello world")
logger2 := logger.WithOptions(zap.Fields(zap.String("key", getUntrustedString()))) // $ zap="call to Fields"
logger2.Info("hello world")
logger3 := logger.WithOptions(zap.Fields(zap.String("key", getUntrustedString()))) // $ SPURIOUS:zap="call to Fields"
logger3 := logger.WithOptions(zap.Fields(zap.String("key", getUntrustedString()))) // $ SPURIOUS: zap="call to Fields"
return logger3
}