hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-28 22:56:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Consider actor and association checks as bypassable checks ONLY for issueOps

Browse Source
This commit is contained in:
Alvaro Muñoz
2024-05-16 16:17:26 +02:00
parent 84d4c573f9
commit dfeefe0caa
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ql/src/Security/CWE-367/UntrustedCheckoutTOCTOUCritical.ql
View File

@@ -15,15 +15,17 @@ import actions
import codeql.actions.security.UntrustedCheckoutQuery
import codeql.actions.security.PoisonableSteps
from LabelControlCheck check, MutableRefCheckoutStep checkout
from ControlCheck check, MutableRefCheckoutStep checkout
where
// the mutable checkout step is protected by an access check
check = [checkout.getIf(), checkout.getEnclosingJob().getIf()] and
// the checked-out code may lead to arbitrary code execution
checkout.getAFollowingStep() instanceof PoisonableStep and
(
// label gates do not depend on the triggering event
check instanceof LabelControlCheck
or
// actor or Association gates apply to IssueOps only
(check instanceof AssociationControlCheck or check instanceof ActorControlCheck) and
check.getEnclosingJob().getATriggerEvent().getName().matches("%_comment")
)

4
ql/src/Security/CWE-367/UntrustedCheckoutTOCTOUHigh.ql
View File

@@ -15,15 +15,17 @@ import actions
import codeql.actions.security.UntrustedCheckoutQuery
import codeql.actions.security.PoisonableSteps
from LabelControlCheck check, MutableRefCheckoutStep checkout
from ControlCheck check, MutableRefCheckoutStep checkout
where
// the mutable checkout step is protected by an access check
check = [checkout.getIf(), checkout.getEnclosingJob().getIf()] and
// there are no evidences that the checked-out code can lead to arbitrary code execution
not checkout.getAFollowingStep() instanceof PoisonableStep and
(
// label gates do not depend on the triggering event
check instanceof LabelControlCheck
or
// actor or Association gates apply to IssueOps only
(check instanceof AssociationControlCheck or check instanceof ActorControlCheck) and
check.getEnclosingJob().getATriggerEvent().getName().matches("%_comment")
)