hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

JavaScript: Fix performance regression in IncorrectSuffixCheck.

Browse Source
This commit is contained in:
Max Schaefer
2019-09-16 15:25:17 +01:00
parent 10076a6b2b
commit df739e0fca
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
javascript/ql/src/Security/CWE-020/IncorrectSuffixCheck.ql
View File

@@ -30,17 +30,26 @@ class IndexOfCall extends DataFlow::MethodCallNode {
result = getArgument(0)
}
/**
* Holds if `recv` is the local source of the receiver of this call, and `m`
* is the name of the invoked method.
*/
private predicate receiverAndMethodName(DataFlow::Node recv, string m) {
this.getReceiver().getALocalSource() = recv and
this.getMethodName() = m
}
/**
* Gets an `indexOf` call with the same receiver, argument, and method name, including this call itself.
*/
IndexOfCall getAnEquivalentIndexOfCall() {
result.getReceiver().getALocalSource() = this.getReceiver().getALocalSource() and
(
exists(DataFlow::Node recv, string m |
this.receiverAndMethodName(recv, m) and result.receiverAndMethodName(recv, m)
|
result.getArgument(0).getALocalSource() = this.getArgument(0).getALocalSource()
or
result.getArgument(0).getStringValue() = this.getArgument(0).getStringValue()
) and
result.getMethodName() = this.getMethodName()
)
}
/**