hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-08 11:11:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #97 from github/fix-spurious-exists-mistakes

Browse Source 
QL: Respond to PR reviews for #87
This commit is contained in:
Mathias Vorreiter Pedersen
2021-10-14 11:03:36 +01:00
committed by GitHub
parent 9749f797c8 ed5960e015
commit deffeff01c
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ql/src/queries/style/SuperfluousExists.ql
View File

@@ -51,8 +51,6 @@ predicate exprImpliesExists(ValueNumber vn, Expr e) {
or
exprImpliesExists(vn, e.(AsExpr).getInnerExpr())
or
exprImpliesExists(vn, e.(Range).getAnEndpoint())
or
exists(ExprAggregate agg |
agg = e and
agg.getKind().matches(["strict%", "unique"]) and
@@ -71,9 +69,8 @@ predicate formulaImpliesExists(ValueNumber vn, Formula f) {
or
exprImpliesExists(vn, f.(ComparisonFormula).getAnOperand())
or
exists(IfFormula ifFormula | ifFormula = f |
exprImpliesExists(vn, ifFormula.getCondition())
or
exists(IfFormula ifFormula |
ifFormula = f and
formulaImpliesExists(vn, ifFormula.getThenPart()) and
formulaImpliesExists(vn, ifFormula.getElsePart())
)