hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Modernize getAnAssignedValue following PR comments

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2020-04-23 14:14:35 +02:00
parent 0fb534c79e
commit deff2820c2
1 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cpp/ql/src/semmle/code/cpp/Variable.qll
View File

@@ -115,10 +115,6 @@ class Variable extends Declaration, @variable {
else result = this.getADeclarationLocation()
}
/** Pulled out of `getAnAssignedValue` to fix a bad join order */
pragma[noinline]
private predicate aggregateLiteralHasType(AggregateLiteral lit, Class c) { lit.getType() = c }
/**
* Gets an expression that is assigned to this variable somewhere in the
* program.
@@ -130,11 +126,7 @@ class Variable extends Declaration, @variable {
or
exists(AssignExpr ae | ae.getLValue().(Access).getTarget() = this and result = ae.getRValue())
or
exists(AggregateLiteral l, Class c |
this.(Field).getDeclaringType() = c and
aggregateLiteralHasType(l, c) and
result = l.getChild(this.(Field).getInitializationOrder())
)
exists(ClassAggregateLiteral l | result = l.getFieldExpr(this))
}
/**