hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #877 from hvitved/csharp/matches-handle

Browse Source 
C#: Use `matchesHandle()` instead of `getLabel()`
This commit is contained in:
Calum Grant
2019-02-06 11:02:09 +00:00
committed by GitHub
parent a2691b32b5 13503d068c
commit dd75e5bce3
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
csharp/ql/src/semmle/code/cil/Declaration.qll
View File

@@ -28,13 +28,13 @@ class Declaration extends DotNet::Declaration, Element, @cil_declaration {
final predicate isSourceDeclaration() { this = getSourceDeclaration() }
}
private CS::Declaration toCSharpNonTypeParameter(Declaration d) { result.getLabel() = d.getLabel() }
private CS::Declaration toCSharpNonTypeParameter(Declaration d) { result.matchesHandle(d) }
private CS::TypeParameter toCSharpTypeParameter(TypeParameter tp) {
toCSharpTypeParameterJoin(tp, result.getIndex(), result.getGeneric())
}
pragma[noinline, nomagic]
pragma[nomagic]
private predicate toCSharpTypeParameterJoin(TypeParameter tp, int i, CS::UnboundGeneric ug) {
exists(TypeContainer tc |
tp.getIndex() = i and

2
csharp/ql/src/semmle/code/dotnet/Element.qll
View File

@@ -93,7 +93,7 @@ class NamedElement extends Element, @dotnet_named_element {
predicate compiledFromSource() {
not this.fromSource() and
exists(NamedElement other | other != this |
other.getLabel() = this.getLabel() and
this.matchesHandle(other) and
other.fromSource()
)
}