hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix isEffectively* predicates to members extracted from multiple assemblies

Browse Source
This commit is contained in:
Tamas Vajk
2021-06-15 16:19:46 +02:00
parent 77f8f3fa8a
commit db8a777aa9
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
csharp/ql/src/semmle/code/csharp/Member.qll
View File

@@ -96,7 +96,12 @@ class Modifiable extends Declaration, @modifiable {
/** Holds if this declaration is `async`. */
predicate isAsync() { this.hasModifier("async") }
private predicate isReallyPrivate() { this.isPrivate() and not this.isProtected() }
private predicate isReallyPrivate() {
this.isPrivate() and
not this.isProtected() and
// Rare case when a member is defined with the same name in multiple assemblies with different visibility
not this.isPublic()
}
/**
* Holds if this declaration is effectively `private`. A declaration is considered
@@ -116,9 +121,13 @@ class Modifiable extends Declaration, @modifiable {
}
private predicate isReallyInternal() {
this.isInternal() and not this.isProtected()
or
this.isPrivate() and this.isProtected()
(
this.isInternal() and not this.isProtected()
or
this.isPrivate() and this.isProtected()
) and
// Rare case when a member is defined with the same name in multiple assemblies with different visibility
not this.isPublic()
}
/**