hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-22 15:25:18 +02:00
Code Issues Packages Projects Releases Wiki Activity

Adjust comments on isEffectively*

Browse Source
This commit is contained in:
Tamas Vajk
2021-04-16 12:07:49 +02:00
parent eea96a5585
commit 77f8f3fa8a
1 changed files with 19 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
csharp/ql/src/semmle/code/csharp/Member.qll
View File

@@ -99,8 +99,15 @@ class Modifiable extends Declaration, @modifiable {
private predicate isReallyPrivate() { this.isPrivate() and not this.isProtected() }
/**
* Holds if this declaration is effectively `private` (either directly or
* because one of the enclosing types is `private`).
* Holds if this declaration is effectively `private`. A declaration is considered
* effectively `private` if it can only be referenced from
* - the declaring and its nested types, similarly to `private` declarations, and
* - the enclosing types.
*
* Note that explicit interface implementation are also considered effectively
* `private` if the implemented interface is itself effectively `private`. Finally,
* `private protected` members are not considered effectively `private`, because
* they can be overriden within the declaring assembly.
*/
predicate isEffectivelyPrivate() {
this.isReallyPrivate() or
@@ -115,8 +122,14 @@ class Modifiable extends Declaration, @modifiable {
}
/**
* Holds if this declaration is effectively `internal` (either directly or
* because one of the enclosing types is `internal`).
* Holds if this declaration is effectively `internal`. A declaration is considered
* effectively `internal` if it can only be referenced from the declaring assembly.
*
* Note that friend assemblies declared in `InternalsVisibleToAttribute` are not
* considered. Explicit interface implementation are also considered effectively
* `internal` if the implemented interface is itself effectively `internal`. Finally,
* `internal protected` members are not considered effectively `internal`, because
* they can be overriden outside the declaring assembly.
*/
predicate isEffectivelyInternal() {
this.isReallyInternal() or
@@ -125,8 +138,8 @@ class Modifiable extends Declaration, @modifiable {
}
/**
* Holds if this declaration is effectively `public`, because it
* and all enclosing types are `public`.
* Holds if this declaration is effectively `public`, meaning that it can be
* referenced outside the declaring assembly.
*/
predicate isEffectivelyPublic() { not isEffectivelyPrivate() and not isEffectivelyInternal() }
}