hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-01-29 22:32:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Refactor to use SummarizedCallable, sourceElement and sinkElement

Browse Source
This commit is contained in:
Owen Mansel-Chan
2021-12-15 12:06:52 -05:00
committed by Owen Mansel-Chan
parent ec3dd1e1c0
commit da8f8e2eef
2 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ql/lib/semmle/go/dataflow/ExternalFlow.qll
View File

@@ -396,6 +396,13 @@ SourceOrSinkElement interpretElement(
)
}
/** Holds if there is an external specification for `f`. */
predicate hasExternalSpecification(Function f) {
f = any(SummarizedCallable sc).asFunction()
or
exists(SourceOrSinkElement e | f = e.asEntity() | sourceElement(e, _, _) or sinkElement(e, _, _))
}
private predicate parseField(string c, DataFlow::FieldContent f) {
specSplit(_, c, _) and
exists(string fieldRegex, string package, string className, string fieldName |

6
ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qll
View File

@@ -713,11 +713,7 @@ module Public {
or
exists(c.(MethodCallNode).getTarget().getBody())
or
exists(string package, string type, string name |
c.(MethodCallNode).getTarget().hasQualifiedName(package, type, name)
|
exists(interpretElement(package, type, _, name, "", _))
)
hasExternalSpecification(c.(DataFlow::MethodCallNode).getTarget())
)
}