hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-28 14:46:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use ControlCheck.dominates in the ImproperAccessControl query

Browse Source
This commit is contained in:
Alvaro Muñoz
2024-08-09 17:05:41 +02:00
parent 9977f25f0f
commit d8df3ff6b3
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
ql/src/Security/CWE-285/ImproperAccessControl.ql
View File

@@ -20,11 +20,6 @@ where
job.getATriggerEvent() = event and
event.getName() = "pull_request_target" and
event.getAnActivityType() = "synchronize" and
job.getAStep() = checkout and
(
checkout.getIf() = check
or
checkout.getEnclosingJob().getIf() = check
)
select checkout, "The checked-out code can be changed after the authorization check o step $@.",
check, check.toString()
check.dominates(checkout)
select checkout, "The checked-out code can be modified after the authorization check $@.", check,
check.toString()