hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 20:25:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Fix extraction of identifiers in EXPORT_BASE context

Browse Source 
This is needed to ensure that the base of the RHS of an ImportEqualsDeclaration is bound to a namespace. That is, B below should be bound to a namespace:

import A = B.C.D;
This commit is contained in:
Asger F
2022-05-20 22:04:11 +02:00
parent 665fa2af59
commit d7e3e9e5db
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/extractor/src/com/semmle/js/extractor/ASTExtractor.java
View File

@@ -747,7 +747,7 @@ public class ASTExtractor {
visit(nd.getProperty(), key, 1, IdContext.TYPE_LABEL);
} else {
IdContext baseIdContext =
c.idcontext == IdContext.EXPORT ? IdContext.EXPORT_BASE : IdContext.VAR_BIND;
(c.idcontext == IdContext.EXPORT || c.idcontext == IdContext.EXPORT_BASE) ? IdContext.EXPORT_BASE : IdContext.VAR_BIND;
visit(nd.getObject(), key, 0, baseIdContext);
visit(nd.getProperty(), key, 1, nd.isComputed() ? IdContext.VAR_BIND : IdContext.LABEL);
}

1
javascript/ql/test/library-tests/TypeScript/RegressionTests/ExportBaseResolution/test.expected
View File

@@ -1 +1,2 @@
| A | namespace | test.d.ts:1:19:1:19 | A | test.d.ts:10:14:10:14 | A |
| A | variable | test.d.ts:1:19:1:19 | A | test.d.ts:10:14:10:14 | A |