hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 02:35:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

use count aggregate to count

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2020-05-18 12:29:46 +02:00
parent 0f82370f4e
commit d7b852f408
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
javascript/ql/src/semmle/javascript/security/dataflow/UnsafeShellCommandConstructionCustomizations.qll
View File

@@ -48,11 +48,7 @@ module UnsafeShellCommandConstruction {
* Gets the number of occurrences of "/" in `path`.
*/
bindingset[path]
private int countSlashes(string path) {
not exists(path.indexOf("/")) and result = 0
or
result = max(int n | exists(path.indexOf("/", n, 0)) | n)
}
private int countSlashes(string path) { result = count(path.splitAt("/")) - 1 }
/**
* Gets the topmost package.json that appears in the project.
@@ -63,7 +59,7 @@ module UnsafeShellCommandConstruction {
private PackageJSON getTopmostPackageJSON() {
result =
min(PackageJSON j |
countSlashes(j.getFile().getRelativePath()) <= 2
countSlashes(j.getFile().getRelativePath()) <= 3
|
j order by countSlashes(j.getFile().getRelativePath())
)