hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 03:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

rename getHighLight() -> getAlertLocation()

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2020-05-18 12:28:28 +02:00
parent 2b1724291b
commit 0f82370f4e
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
javascript/ql/src/Security/CWE-078/UnsafeShellCommandConstruction.ql
View File

@@ -18,5 +18,5 @@ import DataFlow::PathGraph
from Configuration cfg, DataFlow::PathNode source, DataFlow::PathNode sink, Sink sinkNode
where cfg.hasFlowPath(source, sink) and sinkNode = sink.getNode()
select sinkNode.getHighLight(), source, sink, "$@ based on libary input is later used in $@.",
sinkNode.getHighLight(), sinkNode.getSinkType(), sinkNode.getCommandExecution(), "shell command"
select sinkNode.getAlertLocation(), source, sink, "$@ based on libary input is later used in $@.",
sinkNode.getAlertLocation(), sinkNode.getSinkType(), sinkNode.getCommandExecution(), "shell command"

8
javascript/ql/src/semmle/javascript/security/dataflow/UnsafeShellCommandConstructionCustomizations.qll
View File

@@ -36,7 +36,7 @@ module UnsafeShellCommandConstruction {
* Gets the node that should be highlighted for this sink.
* E.g. for a string concatenation, the sink is one of the leaves and the highlight is the concatenation root.
*/
abstract DataFlow::Node getHighLight();
abstract DataFlow::Node getAlertLocation();
}
/**
@@ -156,7 +156,7 @@ module UnsafeShellCommandConstruction {
override SystemCommandExecution getCommandExecution() { result = sys }
override DataFlow::Node getHighLight() { result = root }
override DataFlow::Node getAlertLocation() { result = root }
}
/**
@@ -181,7 +181,7 @@ module UnsafeShellCommandConstruction {
override SystemCommandExecution getCommandExecution() { result = sys }
override DataFlow::Node getHighLight() { result = this }
override DataFlow::Node getAlertLocation() { result = this }
}
/**
@@ -203,7 +203,7 @@ module UnsafeShellCommandConstruction {
override SystemCommandExecution getCommandExecution() { result = sys }
override DataFlow::Node getHighLight() { result = this }
override DataFlow::Node getAlertLocation() { result = this }
}
/**