hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 10:45:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Comments taken into account

Browse Source
This commit is contained in:
Philippe Antoine
2020-07-09 16:05:24 +02:00
parent 5eff8d3165
commit d2763e8149
2 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cpp/ql/src/Likely Bugs/RedundantNullCheckParam.cpp
View File

@@ -1,11 +1,11 @@
void test(char *arg1, int *arg2) {
if (arg1[0] == 'A') {
if (arg2 != NULL) {
if (arg2 != NULL) { //maybe redundant
*arg2 = 42;
}
}
if (arg1[1] == 'B')
{
*arg2 = 54;
*arg2 = 54; //dereferenced without checking first
}
}

7
cpp/ql/src/Likely Bugs/RedundantNullCheckParam.ql
View File

@@ -13,11 +13,6 @@
import cpp
predicate blockDominates(Block check, Block access) {
check.getLocation().getStartLine() <= access.getLocation().getStartLine() and
check.getLocation().getEndLine() >= access.getLocation().getEndLine()
}
predicate isCheckedInstruction(VariableAccess unchecked, VariableAccess checked) {
checked =
any(VariableAccess va |
@@ -25,7 +20,7 @@ predicate isCheckedInstruction(VariableAccess unchecked, VariableAccess checked)
) and
//Simple test if the first access in this code path is dereferenced
not dereferenced(checked) and
blockDominates(checked.getEnclosingBlock(), unchecked.getEnclosingBlock())
bbDominates(checked.getBasicBlock(), unchecked.getBasicBlock())
}
predicate candidateResultUnchecked(VariableAccess unchecked) {