hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-01-29 14:23:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix post-update nodes for function arguments.

Browse Source
This commit is contained in:
Max Schaefer
2020-05-04 09:47:34 +01:00
parent 04a19b7150
commit d0e8d6efda
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ql/src/semmle/go/dataflow/internal/DataFlowUtil.qll
View File

@@ -408,7 +408,7 @@ class PostUpdateNode extends Node {
)
or
preupd instanceof ArgumentNode and
mutableType(preupd.getType())
mutableType(preupd.getType().getUnderlyingType())
) and
(
preupd = this.(SsaNode).getAUse()

1
ql/test/library-tests/semmle/go/dataflow/FunctionInputsAndOutputs/FunctionOutput_getExitNode.expected
View File

@@ -1,3 +1,4 @@
| parameter 0 | tst.go:10:2:10:29 | call to ReadFrom | tst.go:8:12:8:17 | definition of reader |
| receiver | tst.go:10:2:10:29 | call to ReadFrom | tst.go:9:2:9:12 | definition of bytesBuffer |
| result | main.go:51:2:51:14 | call to op | main.go:51:2:51:14 | call to op |
| result | main.go:53:2:53:22 | call to op2 | main.go:53:2:53:22 | call to op2 |