hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-01-29 22:32:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improve code style

Browse Source 
No behavioural changes
This commit is contained in:
Chris Smowton
2020-09-04 17:02:53 +01:00
parent fb85ccb2a5
commit cfba0896f0
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ql/src/semmle/go/frameworks/Protobuf.qll
View File

@@ -64,12 +64,11 @@ module Protobuf {
*/
private class MarshalStateStep extends TaintTracking::AdditionalTaintStep {
override predicate step(DataFlow::Node pred, DataFlow::Node succ) {
exists(DataFlow::Node marshalInput, DataFlow::CallNode marshalStateCall |
exists(DataFlow::PostUpdateNode marshalInput, DataFlow::CallNode marshalStateCall |
marshalStateCall = marshalStateMethod().getACall() and
// pred -> marshalInput.Message
any(DataFlow::Write w)
.writesField(marshalInput.(DataFlow::PostUpdateNode).getPreUpdateNode(),
inputMessageField(), pred) and
.writesField(marshalInput.getPreUpdateNode(), inputMessageField(), pred) and
// marshalInput -> marshalStateCall
marshalStateCall.getArgument(0) = globalValueNumber(marshalInput).getANode() and
// marshalStateCall -> succ
@@ -154,7 +153,7 @@ module Protobuf {
*
* For example, in the expression a.b[c].d[e], this would return the dataflow node for the read from `a`.
*/
DataFlow::Node getUnderlyingNode(DataFlow::ReadNode read) {
private DataFlow::Node getUnderlyingNode(DataFlow::ReadNode read) {
(result = read or result = getBaseLookingThroughDerefs+(read)) and
not result instanceof DataFlow::ComponentReadNode
}