hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Data flow: Remove recommendation to use unique in Node::getEnclosingCallable()

Browse Source
This commit is contained in:
Tom Hvitved
2021-04-12 12:04:23 +02:00
parent f130616369
commit cf5f838b13
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
docs/ql-libraries/dataflow/dataflow.md
View File

@@ -98,10 +98,6 @@ Recommendations:
also work, but the upside of `use-use` steps is that sources defined in terms
of variable reads just work out of the box. It also makes certain
barrier-implementations simpler.
* A predicate `DataFlowCallable Node::getEnclosingCallable()` is required, and in
order to ensure appropriate join-orders, it is important that the QL compiler knows
that this predicate is functional. It can therefore be necessary to enclose the body
of this predicate in a `unique` aggregate.
The shared library does not use `localFlowStep` nor `localFlow` but users of
`DataFlow.qll` may expect the existence of `DataFlow::localFlowStep` and