hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

TypeFlow: Improve join-order.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2025-01-31 12:35:09 +01:00
parent acd31dd701
commit ce976dcc79
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
shared/typeflow/codeql/typeflow/internal/TypeFlowImpl.qll
View File

@@ -85,12 +85,13 @@ module TypeFlow<LocationSig Location, TypeFlowInput<Location> I> {
pragma[nomagic]
private predicate typeBound(Type t) { typeFlow(_, t) }
private predicate hasSupertype(Type sub, Type ancestor) { sub.getASupertype() = ancestor }
/**
* Gets a direct or indirect supertype of this type.
* This does not include itself, unless this type is part of a cycle
* in the type hierarchy.
* Holds if `ancestor` is a direct or indirect supertype of `sub`.
*/
private Type getAStrictAncestor(Type sub) { result = getAnAncestor(sub.getASupertype()) }
private predicate hasAncestorBound(Type sub, Type ancestor) =
doublyBoundedFastTC(hasSupertype/2, typeBound/1, typeBound/1)(sub, ancestor)
/**
* Holds if we have a bound for `n` that is better than `t`.
@@ -98,10 +99,9 @@ module TypeFlow<LocationSig Location, TypeFlowInput<Location> I> {
pragma[nomagic]
private predicate irrelevantBound(TypeFlowNode n, Type t) {
exists(Type bound |
typeFlow(n, bound) and
t = getAStrictAncestor(bound) and
typeBound(t) and
typeFlow(n, pragma[only_bind_into](t)) and
typeFlow(n, pragma[only_bind_into](bound)) and
hasAncestorBound(bound, t) and
typeFlow(n, t) and
not getAnAncestor(t) = bound
or
n.getType() = pragma[only_bind_into](bound) and