hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 09:45:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Rust: Add XSS sink for Axum HTML response creation

Browse Source
This commit is contained in:
Simon Friis Vindum
2025-12-16 10:39:37 +01:00
parent fbf9f7eda7
commit cbdab99497
3 changed files with 32 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
rust/ql/lib/codeql/rust/security/XssExtensions.qll
View File

@@ -59,4 +59,14 @@ module Xss {
)
}
}
// TODO: Convert this to MaD once MaD supports sink for tuple struct expressions.
private class AxumHtmlSink extends Sink {
AxumHtmlSink() {
exists(TupleStructExpr call |
call.getResolvedTarget().getCanonicalPath() = "axum::response::Html" and
this.asExpr() = call.getSyntacticPositionalArgument(0)
)
}
}
}

20
rust/ql/test/query-tests/security/CWE-079/axum/XSS.expected
View File

@@ -1,4 +1,24 @@
#select
| main.rs:10:10:10:21 | html_content | main.rs:15:51:15:53 | get | main.rs:10:10:10:21 | html_content | Cross-site scripting vulnerability due to a $@. | main.rs:15:51:15:53 | get | user-provided value |
edges
| main.rs:8:24:8:59 | ...: Query::<...> | main.rs:9:32:9:63 | MacroExpr | provenance | |
| main.rs:9:9:9:20 | html_content | main.rs:10:10:10:21 | html_content | provenance | |
| main.rs:9:32:9:63 | ...::format(...) | main.rs:9:32:9:63 | { ... } | provenance | |
| main.rs:9:32:9:63 | ...::must_use(...) | main.rs:9:9:9:20 | html_content | provenance | |
| main.rs:9:32:9:63 | MacroExpr | main.rs:9:32:9:63 | ...::format(...) | provenance | MaD:2 |
| main.rs:9:32:9:63 | { ... } | main.rs:9:32:9:63 | ...::must_use(...) | provenance | MaD:3 |
| main.rs:15:51:15:53 | get | main.rs:8:24:8:59 | ...: Query::<...> | provenance | Src:MaD:1 |
models
| 1 | Source: axum::routing::method_routing::get; Argument[0].Parameter[0..7]; remote |
| 2 | Summary: alloc::fmt::format; Argument[0]; ReturnValue; taint |
| 3 | Summary: core::hint::must_use; Argument[0]; ReturnValue; value |
nodes
| main.rs:8:24:8:59 | ...: Query::<...> | semmle.label | ...: Query::<...> |
| main.rs:9:9:9:20 | html_content | semmle.label | html_content |
| main.rs:9:32:9:63 | ...::format(...) | semmle.label | ...::format(...) |
| main.rs:9:32:9:63 | ...::must_use(...) | semmle.label | ...::must_use(...) |
| main.rs:9:32:9:63 | MacroExpr | semmle.label | MacroExpr |
| main.rs:9:32:9:63 | { ... } | semmle.label | { ... } |
| main.rs:10:10:10:21 | html_content | semmle.label | html_content |
| main.rs:15:51:15:53 | get | semmle.label | get |
subpaths

4
rust/ql/test/query-tests/security/CWE-079/axum/main.rs
View File

@@ -7,12 +7,12 @@ struct GreetingParams {
async fn greet_handler(Query(params): Query<GreetingParams>) -> Html<String> {
let html_content = format!("<p>Hello, {}!</p>", params.name);
Html(html_content) // $ MISSING: Alert[rust/xss]
Html(html_content) // $ Alert[rust/xss]=greet
}
#[tokio::main]
pub async fn main() {
let app = Router::<()>::new().route("/greet", get(greet_handler));
let app = Router::<()>::new().route("/greet", get(greet_handler)); // $ Source=greet
let listener = tokio::net::TcpListener::bind("127.0.0.1:3000")
.await
.unwrap();