hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

QL: Remove redundant conjunct in aggregates.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2023-02-24 13:19:52 +00:00
parent 375de59a14
commit c9f8ebd620
1 changed files with 4 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
ql/ql/src/queries/performance/LargeJoinOrder.ql
View File

@@ -76,18 +76,11 @@ predicate hasDuplication(
predicate hasDuplication(ComputeRecursive recursive, string ordering, int i, float duplication) {
duplication =
max(SummaryEvent inLayer, int iteration, int dup |
inLayer = getInLayerOrRecursive(recursive) and
hasDuplication(recursive, ordering, inLayer, iteration, i, dup)
|
dup
)
max(int iteration, int dup | hasDuplication(recursive, ordering, _, iteration, i, dup) | dup)
}
/**
* Holds if the ordering `ordering` has `resultSize` resultSize in the `iteration`'th iteration.
*
* For example, the "base" ordering in iteration 0 has size 42.
*/
private predicate hasResultSize(
ComputeRecursive recursive, string ordering, SummaryEvent inLayer, int iteration, float resultSize
@@ -109,12 +102,7 @@ private predicate hasResultSize(
predicate hasResultSize(ComputeRecursive recursive, string ordering, float resultSize) {
resultSize =
strictsum(InLayer inLayer, int iteration, float r |
inLayer.getComputeRecursiveEvent() = recursive and
hasResultSize(recursive, ordering, inLayer, iteration, r)
|
r
)
strictsum(int iteration, float r | hasResultSize(recursive, ordering, _, iteration, r) | r)
}
RAParser<PipeLine>::RAExpr getAnRaOperation(SummaryEvent inLayer, string ordering) {
@@ -221,9 +209,8 @@ predicate hasDependentPredicateSize(
ComputeRecursive recursive, string ordering, string predicateName, float size
) {
size =
strictsum(SummaryEvent inLayer, int iteration, int s |
inLayer = getInLayerOrRecursive(recursive) and
hasDependentPredicateSize(recursive, ordering, inLayer, iteration, predicateName, s)
strictsum(int iteration, float s |
hasDependentPredicateSize(recursive, ordering, _, iteration, predicateName, s)
|
s
)