hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 03:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Fix comment and prevent false positives on chiOnlyPartiallyUpdatesLocation when Alias::getEndBitOffset doesn't have known value.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2021-03-05 08:53:24 +01:00
parent bd842403c8
commit c86fc223b9
4 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/internal/AliasedSSA.qll
View File

@@ -629,7 +629,11 @@ MemoryLocation getOperandMemoryLocation(MemoryOperand operand) {
}
/** Gets the start bit offset of a `MemoryLocation`, if any. */
int getStartBitOffset(VariableMemoryLocation location) { result = location.getStartBitOffset() }
int getStartBitOffset(VariableMemoryLocation location) {
result = location.getStartBitOffset() and Ints::hasValue(result)
}
/** Gets the end bit offset of a `MemoryLocation`, if any. */
int getEndBitOffset(VariableMemoryLocation location) { result = location.getEndBitOffset() }
int getEndBitOffset(VariableMemoryLocation location) {
result = location.getEndBitOffset() and Ints::hasValue(result)
}

6
cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/internal/SSAConstruction.qll
View File

@@ -179,9 +179,9 @@ private module Cached {
}
/**
* Holds if the `ChiPartialOperand` totally, but not exactly, overlaps with the `ChiTotalOperand`.
* This means that the `ChiPartialOperand` will not override the entire memory associated with the
* `ChiTotalOperand`.
* Holds if the `ChiPartialOperand` only partially overlaps with the `ChiTotalOperand`.
* This means that the `ChiPartialOperand` will not override the entire memory associated
* with the `ChiTotalOperand`.
*/
cached
predicate chiOnlyPartiallyUpdatesLocation(ChiInstruction chi) {

6
cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/SSAConstruction.qll
View File

@@ -179,9 +179,9 @@ private module Cached {
}
/**
* Holds if the `ChiPartialOperand` totally, but not exactly, overlaps with the `ChiTotalOperand`.
* This means that the `ChiPartialOperand` will not override the entire memory associated with the
* `ChiTotalOperand`.
* Holds if the `ChiPartialOperand` only partially overlaps with the `ChiTotalOperand`.
* This means that the `ChiPartialOperand` will not override the entire memory associated
* with the `ChiTotalOperand`.
*/
cached
predicate chiOnlyPartiallyUpdatesLocation(ChiInstruction chi) {

6
csharp/ql/src/experimental/ir/implementation/unaliased_ssa/internal/SSAConstruction.qll
View File

@@ -179,9 +179,9 @@ private module Cached {
}
/**
* Holds if the `ChiPartialOperand` totally, but not exactly, overlaps with the `ChiTotalOperand`.
* This means that the `ChiPartialOperand` will not override the entire memory associated with the
* `ChiTotalOperand`.
* Holds if the `ChiPartialOperand` only partially overlaps with the `ChiTotalOperand`.
* This means that the `ChiPartialOperand` will not override the entire memory associated
* with the `ChiTotalOperand`.
*/
cached
predicate chiOnlyPartiallyUpdatesLocation(ChiInstruction chi) {