hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-19 00:13:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

CFG: Add missing propagatesAbnormal overrides

Browse Source
This commit is contained in:
Tom Hvitved
2021-05-18 20:24:46 +02:00
parent 9871698cee
commit c866f88410
2 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ql/src/codeql_ruby/controlflow/internal/ControlFlowGraphImpl.qll
View File

@@ -880,6 +880,8 @@ module Trees {
}
private class LambdaTree extends BodyStmtTree, Lambda {
final override predicate propagatesAbnormal(AstNode child) { none() }
/** Gets the `i`th child in the body of this block. */
final override AstNode getBodyChild(int i, boolean rescuable) {
result = this.getParameter(i) and rescuable = false
@@ -1158,6 +1160,8 @@ module Trees {
}
private class SingletonMethodTree extends BodyStmtTree, SingletonMethod {
final override predicate propagatesAbnormal(AstNode child) { none() }
/** Gets the `i`th child in the body of this block. */
final override AstNode getBodyChild(int i, boolean rescuable) {
result = this.getParameter(i) and rescuable = false

9
ql/test/library-tests/controlflow/graph/Cfg.expected
View File

@@ -3173,9 +3173,6 @@ raise.rb:
# 1| exit raise.rb
# 1| exit raise.rb (abnormal)
#-----| -> exit raise.rb
# 1| exit raise.rb (normal)
#-----| -> exit raise.rb
@@ -4333,9 +4330,6 @@ raise.rb:
# 159| exit do ... end
# 159| exit do ... end (abnormal)
#-----| -> exit do ... end
# 159| exit do ... end (normal)
#-----| -> exit do ... end
@@ -4363,7 +4357,6 @@ raise.rb:
#-----| -> x
# 161| call to raise
#-----| raise -> exit do ... end (abnormal)
#-----| raise -> exit -> { ... } (abnormal)
# 161| ... unless ...
@@ -4397,9 +4390,7 @@ raise.rb:
#-----| -> m
# 168| call to raise
#-----| raise -> C
#-----| raise -> exit m (abnormal)
#-----| raise -> exit raise.rb (abnormal)
# 168| self
#-----| -> ""