hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 20:25:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

change join order for API::Impl::useStep

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2021-02-17 15:56:05 +01:00
parent ebcecca9f1
commit c80365c48a
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
javascript/ql/src/semmle/javascript/ApiGraphs.qll
View File

@@ -738,9 +738,7 @@ module API {
boundArgs in [0 .. 10]
)
or
exists(StepSummary summary |
t = useStep(nd, promisified, boundArgs, result, summary).append(summary)
)
t = useStep(nd, promisified, boundArgs, result)
}
private import semmle.javascript.dataflow.internal.StepSummary
@@ -748,15 +746,19 @@ module API {
/**
* Holds if `nd`, which is a use of an API-graph node, flows in zero or more potentially
* inter-procedural steps to some intermediate node, and then from that intermediate node to
* `res` in one step described by `summary`.
* `res` in one step described by the resulting TypeTracker.
*
* This predicate exists solely to enforce a better join order in `trackUseNode` above.
*/
pragma[noinline]
pragma[noopt]
private DataFlow::TypeTracker useStep(
DataFlow::Node nd, boolean promisified, int boundArgs, DataFlow::Node res, StepSummary summary
DataFlow::Node nd, boolean promisified, int boundArgs, DataFlow::Node res
) {
StepSummary::step(trackUseNode(nd, promisified, boundArgs, result), res, summary)
exists(DataFlow::TypeTracker t, StepSummary summary, DataFlow::SourceNode prev |
prev = trackUseNode(nd, promisified, boundArgs, t) and
StepSummary::step(prev, res, summary) and
result = t.append(summary)
)
}
private DataFlow::SourceNode trackUseNode(