hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 03:06:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++ IR: getAnyDef -> getDef in SignAnalysis

Browse Source 
For signs that follow from guards, we want the guard and the guarded
access to overlap exactly.
This commit is contained in:
Jonas Jensen
2019-07-01 13:37:16 +02:00
parent a16ed7d613
commit c62f73e2a2
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cpp/ql/src/semmle/code/cpp/rangeanalysis/SignAnalysis.qll
View File

@@ -221,7 +221,7 @@ private predicate unknownSign(Instruction i) {
*/
private predicate lowerBound(IRGuardCondition comp, Operand lowerbound, Operand bounded, boolean isStrict) {
exists(int adjustment, Operand compared |
valueNumber(bounded.getAnyDef()) = valueNumber(compared.getAnyDef()) and
valueNumberOfOperand(bounded) = valueNumberOfOperand(compared) and
(
isStrict = true and
adjustment = 0
@@ -240,7 +240,7 @@ private predicate lowerBound(IRGuardCondition comp, Operand lowerbound, Operand
*/
private predicate upperBound(IRGuardCondition comp, Operand upperbound, Operand bounded, boolean isStrict) {
exists(int adjustment, Operand compared |
valueNumber(bounded.getAnyDef()) = valueNumber(compared.getAnyDef()) and
valueNumberOfOperand(bounded) = valueNumberOfOperand(compared) and
(
isStrict = true and
adjustment = 0
@@ -261,7 +261,7 @@ private predicate upperBound(IRGuardCondition comp, Operand upperbound, Operand
*/
private predicate eqBound(IRGuardCondition guard, Operand eqbound, Operand bounded, boolean isEq) {
exists(Operand compared |
valueNumber(bounded.getAnyDef()) = valueNumber(compared.getAnyDef()) and
valueNumberOfOperand(bounded) = valueNumberOfOperand(compared) and
guard.ensuresEq(compared, eqbound, 0, bounded.getUse().getBlock(), isEq)
)
}