hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 10:45:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++ IR: getAnyDef -> getDef in ValueNumbering

Browse Source 
This change seems more in line with what users would expect.
This commit is contained in:
Jonas Jensen
2019-07-01 12:54:32 +02:00
parent 2ce8612a05
commit a16ed7d613
3 changed files with 24 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/gvn/ValueNumbering.qll
View File

@@ -86,9 +86,12 @@ class ValueNumber extends TValueNumber {
instr order by instr.getBlock().getDisplayIndex(), instr.getDisplayIndexInBlock()
)
}
/**
* Gets an `Operand` whose definition is exact and has this value number.
*/
final Operand getAUse() {
this = valueNumber(result.getAnyDef())
this = valueNumber(result.getDef())
}
}
@@ -227,10 +230,11 @@ cached ValueNumber valueNumber(Instruction instr) {
}
/**
* Gets the value number assigned to `instr`, if any. Returns at most one result.
* Gets the value number assigned to the exact definition of `op`, if any.
* Returns at most one result.
*/
ValueNumber valueNumberOfOperand(Operand op) {
result = valueNumber(op.getAnyDef())
result = valueNumber(op.getDef())
}
/**

12
cpp/ql/src/semmle/code/cpp/ir/implementation/raw/gvn/ValueNumbering.qll
View File

@@ -86,9 +86,12 @@ class ValueNumber extends TValueNumber {
instr order by instr.getBlock().getDisplayIndex(), instr.getDisplayIndexInBlock()
)
}
/**
* Gets an `Operand` whose definition is exact and has this value number.
*/
final Operand getAUse() {
this = valueNumber(result.getAnyDef())
this = valueNumber(result.getDef())
}
}
@@ -227,10 +230,11 @@ cached ValueNumber valueNumber(Instruction instr) {
}
/**
* Gets the value number assigned to `instr`, if any. Returns at most one result.
* Gets the value number assigned to the exact definition of `op`, if any.
* Returns at most one result.
*/
ValueNumber valueNumberOfOperand(Operand op) {
result = valueNumber(op.getAnyDef())
result = valueNumber(op.getDef())
}
/**

12
cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/gvn/ValueNumbering.qll
View File

@@ -86,9 +86,12 @@ class ValueNumber extends TValueNumber {
instr order by instr.getBlock().getDisplayIndex(), instr.getDisplayIndexInBlock()
)
}
/**
* Gets an `Operand` whose definition is exact and has this value number.
*/
final Operand getAUse() {
this = valueNumber(result.getAnyDef())
this = valueNumber(result.getDef())
}
}
@@ -227,10 +230,11 @@ cached ValueNumber valueNumber(Instruction instr) {
}
/**
* Gets the value number assigned to `instr`, if any. Returns at most one result.
* Gets the value number assigned to the exact definition of `op`, if any.
* Returns at most one result.
*/
ValueNumber valueNumberOfOperand(Operand op) {
result = valueNumber(op.getAnyDef())
result = valueNumber(op.getDef())
}
/**