Merge pull request #21990 from jketema/jketema/telemetry-prep

Java: Use fixture for filtering diagnostics

java/ql/integration-tests/java/buildless-erroneous/test.py

@@ -1,2 +1,2 @@
-def test(codeql, java):
+def test(codeql, java, check_diagnostics_java):
     codeql.database.create(_env={"CODEQL_EXTRACTOR_JAVA_OPTION_BUILDLESS": "true"})

java/ql/integration-tests/java/buildless-gradle-boms/test.py

@@ -1,4 +1,4 @@
-def test(codeql, java, gradle_8_3):
+def test(codeql, java, gradle_8_3, check_diagnostics_java):
     codeql.database.create(
         _env={
             "CODEQL_EXTRACTOR_JAVA_OPTION_BUILDLESS": "true",

java/ql/integration-tests/java/buildless-gradle-classifiers/test.py

@@ -1,4 +1,4 @@
-def test(codeql, java, gradle_8_3):
+def test(codeql, java, gradle_8_3, check_diagnostics_java):
     codeql.database.create(
         _env={
             "CODEQL_EXTRACTOR_JAVA_OPTION_BUILDLESS": "true",

java/ql/integration-tests/java/buildless-gradle-timeout/test.py

@@ -1,4 +1,4 @@
-def test(codeql, java):
+def test(codeql, java, check_diagnostics_java):
     # gradlew has been rigged to stall for a long time by trying to fetch from a black-hole IP.
     # We should find the timeout logic fires and buildless aborts the Gradle run quickly.
     codeql.database.create(

java/ql/integration-tests/java/buildless-gradle/test.py

@@ -1,4 +1,4 @@
-def test(codeql, java, gradle_8_3):
+def test(codeql, java, gradle_8_3, check_diagnostics_java):
     codeql.database.create(
         _env={
             "CODEQL_EXTRACTOR_JAVA_OPTION_BUILDLESS": "true",

java/ql/integration-tests/java/buildless-inherit-trust-store/test.py

@@ -3,7 +3,7 @@ import os
 import runs_on
 
 
-def test(codeql, java, cwd):
+def test(codeql, java, cwd, check_diagnostics_java):
     # This serves the "repo" directory on https://locahost:4443
     command = ["python3", "../server.py"]
     if runs_on.github_actions and runs_on.posix:

java/ql/integration-tests/java/buildless-maven-executable-war/test.py

@@ -1,4 +1,4 @@
-def test(codeql, java):
+def test(codeql, java, check_diagnostics_java):
     codeql.database.create(
         _env={
             "CODEQL_EXTRACTOR_JAVA_OPTION_BUILDLESS": "true",

java/ql/integration-tests/java/buildless-maven-existing-settings-xml/test.py

@@ -1,7 +1,7 @@
 import os
 import os.path
 
-def test(codeql, java):
+def test(codeql, java, check_diagnostics_java):
     codeql.database.create(build_mode = "none",
         _env={
             "_JAVA_OPTIONS": "-Duser.home=" + os.path.join(os.getcwd(), "home-dir-with-maven-settings")

java/ql/integration-tests/java/buildless-maven-mirrorof/test.py

@@ -1,7 +1,7 @@
 import os
 import os.path
 
-def test(codeql, java):
+def test(codeql, java, check_diagnostics_java):
     codeql.database.create(build_mode = "none",
         _env={
             "_JAVA_OPTIONS": "-Duser.home=" + os.path.join(os.getcwd(), "empty-home"),

java/ql/integration-tests/java/buildless-maven-multimodule/test.py

@@ -1,4 +1,4 @@
-def test(codeql, java):
+def test(codeql, java, check_diagnostics_java):
     codeql.database.create(
         _env={
             "CODEQL_EXTRACTOR_JAVA_OPTION_BUILDLESS": "true",

java/ql/integration-tests/java/buildless-maven-timeout/test.py

@@ -1,4 +1,4 @@
-def test(codeql, java):
+def test(codeql, java, check_diagnostics_java):
     # mvnw has been rigged to stall for a long time by trying to fetch from a black-hole IP. We should find the timeout logic fires and buildless aborts the Maven run quickly.
     codeql.database.create(
         build_mode="none",

java/ql/integration-tests/java/buildless-maven/test.py

@@ -1,7 +1,7 @@
 import os
 import os.path
 
-def test(codeql, java):
+def test(codeql, java, check_diagnostics_java):
     codeql.database.create(build_mode = "none",
         _env={
             "_JAVA_OPTIONS": "-Duser.home=" + os.path.join(os.getcwd(), "empty-home")

java/ql/integration-tests/java/buildless-proxy-gradle/test.py

@@ -1,4 +1,4 @@
-def test(codeql, java, codeql_mitm_proxy, gradle_8_3):
+def test(codeql, java, codeql_mitm_proxy, gradle_8_3, check_diagnostics_java):
     codeql.database.create(
         _env={
             "CODEQL_EXTRACTOR_JAVA_OPTION_BUILDLESS": "true",

java/ql/integration-tests/java/buildless-proxy-maven/test.py

@@ -1,4 +1,4 @@
-def test(codeql, java, codeql_mitm_proxy):
+def test(codeql, java, codeql_mitm_proxy, check_diagnostics_java):
     codeql.database.create(
         _env={
             "CODEQL_EXTRACTOR_JAVA_OPTION_BUILDLESS": "true",

java/ql/integration-tests/java/buildless-sibling-projects/test.py

@@ -1,4 +1,4 @@
-def test(codeql, use_java_11, java, actions_toolchains_file):
+def test(codeql, use_java_11, java, actions_toolchains_file, check_diagnostics_java):
     # The version of gradle used doesn't work on java 17
     codeql.database.create(
         _env={

java/ql/integration-tests/java/buildless/test.py

@@ -1,2 +1,2 @@
-def test(codeql, java):
+def test(codeql, java, check_diagnostics_java):
     codeql.database.create(_env={"CODEQL_EXTRACTOR_JAVA_OPTION_BUILDLESS": "true"})