hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-01-30 14:52:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add test showing false-negative for MarshalState

Browse Source
This commit is contained in:
Chris Smowton
2020-08-12 12:55:01 +01:00
parent 42d6250b8d
commit c2ff2df403
2 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
ql/test/library-tests/semmle/go/frameworks/Protobuf/FunctionModel.expected
View File

@@ -40,3 +40,4 @@
| testModernApi.go:123:18:123:36 | untrustedSerialized | testModernApi.go:122:2:122:6 | definition of query |
| testModernApi.go:143:33:143:37 | query | testModernApi.go:143:2:143:38 | ... := ...[0] |
| testModernApi.go:154:33:154:37 | query | testModernApi.go:154:2:154:38 | ... := ...[0] |
| testModernApi.go:168:12:168:16 | query | testModernApi.go:168:12:168:31 | call to ProtoReflect |

19
ql/test/library-tests/semmle/go/frameworks/Protobuf/testModernApi.go
View File

@@ -155,3 +155,22 @@ func testSubmessageAliasFalseNegativeModern() {
sinkBytes(serialized) // BAD (but not noticed by our current implementation)
}
// This test should be flagged, but we don't notice that marshalState2.Message is the
// same as marshalState.Message.
func testMarshalStateFalseNegative() {
query := &query.Query{}
query.Description = getUntrustedString()
options := proto.MarshalOptions{}
emptyArray := []byte{}
marshalState := protoiface.MarshalInput{
Message: query.ProtoReflect(),
Buf: emptyArray,
Flags: 0,
}
marshalState2 := marshalState
serialized, _ := options.MarshalState(marshalState2)
sinkBytes(serialized.Buf) // BAD (but not noticed by our current implementation)
}