Fix tests

csharp/extractor/Semmle.Extraction.CSharp/Entities/Parameter.cs

@@ -164,12 +164,10 @@ namespace Semmle.Extraction.CSharp.Entities
                 // In case this parameter belongs to an accessor of an indexer, we need
                 // to get the default value from the corresponding parameter belonging
                 // to the indexer itself
-                var method = (IMethodSymbol)symbol.ContainingSymbol;
-                if (method is not null)
+                if (symbol.ContainingSymbol is IMethodSymbol method)
                 {
                     var i = method.Parameters.IndexOf(symbol);
-                    var indexer = (IPropertySymbol?)method.AssociatedSymbol;
-                    if (indexer is not null)
+                    if (method.AssociatedSymbol is IPropertySymbol indexer)
                         defaultValue = GetParameterDefaultValue(indexer.Parameters[i]);
                 }
             }

csharp/ql/src/semmle/code/csharp/Element.qll

@@ -27,9 +27,6 @@ class Element extends DotNet::Element, @element {
   /** Gets a location of this element, including sources and assemblies. */
   override Location getALocation() { none() }
 
-  /** Holds if this element is from an assembly. */
-  predicate fromLibrary() { this.getFile().fromLibrary() }
-
   /** Gets the parent of this element, if any. */
   Element getParent() { result.getAChild() = this }
 

csharp/ql/src/semmle/code/dotnet/Element.qll

@@ -28,6 +28,9 @@ class Element extends @dotnet_element {
   /** Holds if this element is from source code. */
   predicate fromSource() { this.getFile().fromSource() }
 
+  /** Holds if this element is from an assembly. */
+  predicate fromLibrary() { this.getFile().fromLibrary() }
+
   /**
    * Gets the "language" of this program element, as defined by the extension of the filename.
    * For example, C# has language "cs", and Visual Basic has language "vb".

csharp/ql/test/library-tests/controlflow/graph/BasicBlock.ql

@@ -2,4 +2,5 @@ import csharp
 import Common
 
 from SourceBasicBlock bb
+where not bb.getFirstNode().getElement().fromLibrary()
 select bb.getFirstNode(), bb.getLastNode(), bb.length()

csharp/ql/test/library-tests/controlflow/graph/Dominance.ql

@@ -1,18 +1,25 @@
 import csharp
 import Common
 
+/** Holds if `node` is not from a library. */
+private predicate isSourceBased(SourceControlFlowNode node) { not node.getElement().fromLibrary() }
+
 query predicate dominance(SourceControlFlowNode dom, SourceControlFlowNode node) {
+  isSourceBased(dom) and
   dom.strictlyDominates(node) and
   dom.getASuccessor() = node
 }
 
 query predicate postDominance(SourceControlFlowNode dom, SourceControlFlowNode node) {
+  isSourceBased(dom) and
   dom.strictlyPostDominates(node) and
   dom.getAPredecessor() = node
 }
 
-query predicate blockDominance(SourceBasicBlock dom, SourceBasicBlock bb) { dom.dominates(bb) }
+query predicate blockDominance(SourceBasicBlock dom, SourceBasicBlock bb) {
+  isSourceBased(dom.getFirstNode()) and dom.dominates(bb)
+}
 
 query predicate postBlockDominance(SourceBasicBlock dom, SourceBasicBlock bb) {
-  dom.postDominates(bb)
+  isSourceBased(dom.getFirstNode()) and dom.postDominates(bb)
 }

csharp/ql/test/library-tests/controlflow/graph/NodeGraph.ql

@@ -4,6 +4,7 @@ import Common
 query predicate edges(
   SourceControlFlowNode node, SourceControlFlowNode successor, string attr, string val
 ) {
+  not node.getElement().fromLibrary() and
   exists(ControlFlow::SuccessorType t | successor = node.getASuccessorByType(t) |
     attr = "semmle.label" and
     val = t.toString()

csharp/ql/test/library-tests/controlflow/splits/SplittingStressTest.ql

@@ -1,6 +1,7 @@
 import csharp
 
 query predicate countSplits(ControlFlowElement cfe, int i) {
+  not cfe.fromLibrary() and
   i = strictcount(ControlFlow::Nodes::ElementNode n | n.getElement() = cfe)
 }
 

csharp/ql/test/library-tests/csharp7.1/DefaultLiterals.ql

@@ -1,4 +1,5 @@
 import csharp
 
 from DefaultValueExpr l
+where l.fromSource()
 select l, l.getValue()

csharp/ql/test/library-tests/csharp7/LocalTaintFlow.ql

@@ -2,5 +2,7 @@ import csharp
 import semmle.code.csharp.dataflow.TaintTracking
 
 from DataFlow::Node pred, DataFlow::Node succ
-where TaintTracking::localTaintStep(pred, succ)
+where
+  TaintTracking::localTaintStep(pred, succ) and
+  not pred.asExpr().fromLibrary()
 select pred, succ

csharp/ql/test/library-tests/dataflow/local/DataFlowStep.ql

@@ -1,5 +1,5 @@
 import csharp
 
 from DataFlow::Node pred, DataFlow::Node succ
-where DataFlow::localFlowStep(pred, succ)
+where not pred.asExpr().fromLibrary() and DataFlow::localFlowStep(pred, succ)
 select pred, succ

csharp/ql/test/library-tests/dataflow/local/TaintTrackingStep.ql

@@ -1,5 +1,7 @@
 import csharp
 
 from DataFlow::Node pred, DataFlow::Node succ
-where TaintTracking::localTaintStep(pred, succ)
+where
+  not pred.asExpr().fromLibrary() and
+  TaintTracking::localTaintStep(pred, succ)
 select pred, succ

csharp/ql/test/library-tests/dataflow/modulusanalysis/ModulusAnalysis.ql

@@ -4,5 +4,7 @@ import semmle.code.csharp.dataflow.ModulusAnalysis
 import semmle.code.csharp.dataflow.Bound
 
 from ControlFlow::Nodes::ExprNode e, Bound b, int delta, int mod
-where exprModulus(e, b, delta, mod)
+where
+  not e.getExpr().fromLibrary() and
+  exprModulus(e, b, delta, mod)
 select e, b.toString(), delta, mod

csharp/ql/test/library-tests/dataflow/signanalysis/SignAnalysis.ql

@@ -18,4 +18,5 @@ string getASignString(ControlFlow::Nodes::ExprNode e) {
 }
 
 from ControlFlow::Nodes::ExprNode e
+where not e.getExpr().fromLibrary()
 select e, strictconcat(string s | s = getASignString(e) | s, " ")

csharp/ql/test/library-tests/dataflow/tuples/DataFlowStep.ql

@@ -1,5 +1,5 @@
 import csharp
 
 from DataFlow::Node pred, DataFlow::Node succ
-where DataFlow::localFlowStep(pred, succ)
+where not pred.asExpr().fromLibrary() and DataFlow::localFlowStep(pred, succ)
 select pred, succ

csharp/ql/test/library-tests/exprorstmtparent/Parameter.ql

@@ -1,4 +1,5 @@
 import csharp
 
 from Parameter p
+where p.fromSource()
 select p, p.getDefaultValue()

csharp/ql/test/library-tests/goto/Goto1.ql

@@ -1,6 +1,7 @@
 import csharp
 
 query predicate edges(ControlFlow::Node node, ControlFlow::Node successor, string attr, string val) {
+  not node.getElement().fromLibrary() and
   exists(ControlFlow::SuccessorType t | successor = node.getASuccessorByType(t) |
     attr = "semmle.label" and
     val = t.toString()

csharp/ql/test/library-tests/standalone/controlflow/cfg.ql

@@ -17,4 +17,6 @@ class UnknownLocalVariableDeclExpr extends LocalVariableDeclAndInitExpr {
   override string toString() { result = "(unknown type) " + this.getName() }
 }
 
-query predicate edges(ControlFlow::Node n1, ControlFlow::Node n2) { n2 = n1.getASuccessor() }
+query predicate edges(ControlFlow::Node n1, ControlFlow::Node n2) {
+  not n1.getElement().fromLibrary() and n2 = n1.getASuccessor()
+}