hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Guards: Disregard more trivial guards.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2025-09-26 10:08:49 +02:00
parent ca7d56023a
commit c01ac307b0
1 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
shared/controlflow/codeql/controlflow/Guards.qll
View File

@@ -505,7 +505,8 @@ module Make<
or
exists(NonNullExpr nonnull |
equalityTestSymmetric(g1, g2, nonnull, v1.asBooleanValue()) and
v2.isNonNullValue()
v2.isNonNullValue() and
not g2 instanceof NonNullExpr // disregard trivial guard
)
or
exists(Case c1, Expr switchExpr |
@@ -801,13 +802,16 @@ module Make<
}
private predicate impliesStep2(Guard g1, GuardValue v1, Guard g2, GuardValue v2) {
impliesStep1(g1, v1, g2, v2)
or
exists(Expr nonnull |
exprHasValue(nonnull, v2) and
equalityTestSymmetric(g1, g2, nonnull, v1.asBooleanValue()) and
v2.isNonNullValue()
)
(
impliesStep1(g1, v1, g2, v2)
or
exists(Expr nonnull |
exprHasValue(nonnull, v2) and
equalityTestSymmetric(g1, g2, nonnull, v1.asBooleanValue()) and
v2.isNonNullValue()
)
) and
not exprHasValue(g2, v2) // disregard trivial guard
}
bindingset[g1, v1]