hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: remove comments about Java implies predicates

Browse Source 
The Java guards library includes a set of "implies" predicates to handle
short-circuiting conditionals. C++ handles those in IR generation, so
dominance on the IR produces correct results for controlling blocks.
This commit is contained in:
Robert Marsh
2018-09-20 11:35:50 -07:00
parent 554fea46c7
commit bf946c3ec3
1 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
cpp/ql/src/semmle/code/cpp/rangeanalysis/SignAnalysis.qll
View File

@@ -214,10 +214,6 @@ private predicate lowerBound(IRGuardCondition comp, Instruction lowerbound, Inst
valueNumber(bounded) = valueNumber(compared) and
bounded = pos.getAnOperand() and
not unknownSign(lowerbound) and
/*
* Java library uses guardControlsSsaRead here. I think that the phi node logic doesn't need to
* be duplicated but the implication predicates may need to be ported
*/
(
isStrict = true and
adjustment = 0
@@ -239,11 +235,6 @@ private predicate upperBound(IRGuardCondition comp, Instruction upperbound, Inst
valueNumber(bounded) = valueNumber(compared) and
bounded = pos.getAnOperand() and
not unknownSign(upperbound) and
/*
* Java library uses guardControlsSsaRead here. I think that the phi node logic doesn't need to
* be duplicated but the implication predicates may need to be ported
*/
(
isStrict = true and
adjustment = 0