hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-06-06 05:57:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix CFG for range loop

Browse Source
This commit is contained in:
Owen Mansel-Chan
2026-05-28 16:27:11 +01:00
parent 481564668d
commit bee9ead570
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
go/ql/lib/semmle/go/controlflow/ControlFlowGraphShared.qll
View File

@@ -1195,11 +1195,13 @@ module GoCfg {
private predicate rangeLoop(PreControlFlowNode n1, PreControlFlowNode n2) {
exists(Go::RangeStmt s |
// Use the shared library's auto-created `[LoopHeader]` additional node
// (created for every `LoopStmt`) as the join/branch point of the range loop.
n1.isBefore(s) and n2.isBefore(s.getDomain())
or
n1.isAfter(s.getDomain()) and n2.isIn(s)
n1.isAfter(s.getDomain()) and n2.isAdditional(s, "[LoopHeader]")
or
n1.isIn(s) and
n1.isAdditional(s, "[LoopHeader]") and
(
n2.isBefore(s.getKey())
or
@@ -1215,9 +1217,9 @@ module GoCfg {
or
n1.isAfter(s.getValue()) and n2.isBefore(s.getBody())
or
n1.isAfter(s.getBody()) and n2.isIn(s)
n1.isAfter(s.getBody()) and n2.isAdditional(s, "[LoopHeader]")
or
n1.isIn(s) and n2.isAfter(s)
n1.isAdditional(s, "[LoopHeader]") and n2.isAfter(s)
)
}