hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-03 12:45:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: address doc review comments

Browse Source
This commit is contained in:
Esben Sparre Andreasen
2018-09-17 11:08:35 +02:00
parent 444a09a17c
commit bb48421d77
3 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
change-notes/1.19/analysis-javascript.md
View File

@@ -12,7 +12,7 @@
| **Query** | **Tags** | **Purpose** |
|-----------------------------------------------|------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| Stored cross-site scripting (`js/stored-xss`) | security, external/cwe/cwe-079, external/cwe/cwe-116 | Highlights uncontrolled stored values flowing into HTML content, indicating a violation of [CWE-079](https://cwe.mitre.org/data/definitions/79.html). Results shown on lgtm by default. |
| Stored cross-site scripting (`js/stored-xss`) | security, external/cwe/cwe-079, external/cwe/cwe-116 | Highlights uncontrolled stored values flowing into HTML content, indicating a violation of [CWE-079](https://cwe.mitre.org/data/definitions/79.html). Results shown on LGTM by default. |
## Changes to existing queries

3
javascript/ql/src/Security/CWE-079/examples/StoredXss.js
View File

@@ -5,7 +5,8 @@ express().get('/list-directory', function(req, res) {
fs.readdir('/public', function (error, fileNames) {
var list = '<ul>';
fileNames.forEach(fileName => {
list += '<li>' + fileName '</li>'; // BAD: `fileName` can contain HTML elements
// BAD: `fileName` can contain HTML elements
list += '<li>' + fileName '</li>';
});
list += '</ul>'
res.send(list);

3
javascript/ql/src/Security/CWE-079/examples/StoredXssGood.js
View File

@@ -6,7 +6,8 @@ express().get('/list-directory', function(req, res) {
fs.readdir('/public', function (error, fileNames) {
var list = '<ul>';
fileNames.forEach(fileName => {
list += '<li>' + escape(fileName) '</li>'; // GOOD: escaped `fileName` can not contain HTML elements
// GOOD: escaped `fileName` can not contain HTML elements
list += '<li>' + escape(fileName) '</li>';
});
list += '</ul>'
res.send(list);