hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 11:45:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

apply review comments

Browse Source
This commit is contained in:
Jami Cogswell
2022-11-08 09:34:46 -05:00
parent b99a1d2cd9
commit bada986433
2 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/ql/lib/semmle/code/java/security/regexp/RegexInjection.qll
View File

@@ -40,11 +40,10 @@ private class PatternQuoteCall extends RegexInjectionSanitizer {
*/
private class PatternLiteralFlag extends RegexInjectionSanitizer {
PatternLiteralFlag() {
exists(MethodAccess ma, Method m, Field field | m = ma.getMethod() |
exists(MethodAccess ma, Method m, PatternLiteralField field | m = ma.getMethod() |
ma.getArgument(0) = this.asExpr() and
m.getDeclaringType() instanceof TypeRegexPattern and
m.hasName("compile") and
field instanceof PatternLiteralField and
ma.getArgument(1) = field.getAnAccess()
)
}

1
java/ql/test/query-tests/security/CWE-730/RegexInjectionTest.ql
View File

@@ -2,7 +2,6 @@ import java
import TestUtilities.InlineExpectationsTest
import semmle.code.java.security.regexp.RegexInjectionQuery
//import semmle.code.java.security.regexp.PolynomialReDoSQuery
class RegexInjectionTest extends InlineExpectationsTest {
RegexInjectionTest() { this = "RegexInjectionTest" }