hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-22 23:35:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Shared: Address model generator review comments.

Browse Source
This commit is contained in:
Michael Nebel
2024-09-30 09:12:30 +02:00
parent 0b39c5b982
commit baae8d0bb2
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
shared/mad/codeql/mad/modelgenerator/internal/ModelGeneratorImpl.qll
View File

@@ -673,23 +673,21 @@ module MakeModelGenerator<
}
private string getReversedHash(PropagateContentFlow::AccessPath ap) {
result = concat(int i | | getHashAtIndex(ap, i), "" order by i desc)
result = strictconcat(int i | | getHashAtIndex(ap, i), "." order by i desc)
}
private string getHash(PropagateContentFlow::AccessPath ap) {
result = concat(int i | | getHashAtIndex(ap, i), "" order by i)
result = strictconcat(int i | | getHashAtIndex(ap, i), "." order by i)
}
/**
* Gets all access paths that contains the synthetic fields
* Gets all access paths that contain the synthetic fields
* from `ap` in reverse order (if `ap` contains at least one synthetic field).
* These are the possible candidates for synthetic path continuations.
*/
private PropagateContentFlow::AccessPath getSyntheticPathCandidate(
PropagateContentFlow::AccessPath ap
) {
hasSyntheticContent(ap) and
hasSyntheticContent(result) and
getHash(ap) = getReversedHash(result)
}