hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 02:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Simplify the isCollectionType predicate.

Browse Source
This commit is contained in:
Michael Nebel
2022-03-22 11:25:14 +01:00
parent 92f8a90f31
commit b95a332ded
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
csharp/ql/lib/semmle/code/csharp/commons/Collections.qll
View File

@@ -2,7 +2,6 @@
import csharp
import semmle.code.csharp.frameworks.system.Collections
import semmle.code.csharp.frameworks.system.collections.Generic
private string modifyMethodName() {
result =
@@ -70,11 +69,8 @@ class CollectionType extends RefType {
/** Holds if `t` is a collection type. */
predicate isCollectionType(ValueOrRefType t) {
not t instanceof StringType and
exists(ValueOrRefType base | base = t.getABaseType*() |
base instanceof SystemCollectionsGenericIEnumerableTInterface or
base instanceof SystemCollectionsIEnumerableInterface
)
t.getABaseType*() instanceof SystemCollectionsIEnumerableInterface and
not t instanceof StringType
}
/** An object creation that creates an empty collection. */