hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-11 20:51:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

JS: Moving 'cache' annotations outside the parameterised module

Browse Source
This commit is contained in:
Asger F
2025-10-09 15:17:36 +02:00
parent 10db30a715
commit b69f8532d0
1 changed files with 30 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
javascript/ql/lib/semmle/javascript/ApiGraphs.qll
View File

@@ -818,7 +818,6 @@ module API {
predicate inScope(DataFlow::Node node);
}
cached
private module Stage<StageInputSig S> {
/**
* Holds if `rhs` is the right-hand side of a definition of a node that should have an
@@ -1010,7 +1009,6 @@ module API {
/**
* Holds if `rhs` is the right-hand side of a definition of node `nd`.
*/
cached
predicate rhs(TApiNode nd, DataFlow::Node rhs) {
(S::inScope(rhs) or S::isAdditionalDefRoot(nd)) and
exists(string m | nd = MkModuleExport(m) | exports(m, rhs))
@@ -1258,7 +1256,6 @@ module API {
/**
* Holds if `ref` is a use of node `nd`.
*/
cached
predicate use(TApiNode nd, DataFlow::Node ref) {
(S::inScope(ref) or S::isAdditionalUseRoot(nd)) and
(
@@ -1380,7 +1377,6 @@ module API {
/**
* Gets a node that is inter-procedurally reachable from `nd`, which is a use of some node.
*/
cached
DataFlow::SourceNode trackUseNode(DataFlow::SourceNode nd) {
result = trackUseNode(nd, false, 0, "")
}
@@ -1431,7 +1427,6 @@ module API {
/**
* Gets a node that inter-procedurally flows into `nd`, which is a definition of some node.
*/
cached
DataFlow::SourceNode trackDefNode(DataFlow::Node nd) {
result = trackDefNode(nd, DataFlow::TypeBackTracker::end())
}
@@ -1454,7 +1449,6 @@ module API {
/**
* Holds if there is an edge from `pred` to `succ` in the API graph that is labeled with `lbl`.
*/
cached
predicate edge(TApiNode pred, Label::ApiLabel lbl, TApiNode succ) {
Stages::ApiStage::ref() and
exists(string m |
@@ -1520,7 +1514,6 @@ module API {
* Gets a call to a promisified function represented by `callee` where
* `bound` arguments have been bound.
*/
cached
DataFlow::InvokeNode getAPromisifiedInvocation(TApiNode callee, int bound, TApiNode succ) {
exists(DataFlow::SourceNode src |
use(callee, src) and
@@ -1541,7 +1534,36 @@ module API {
predicate inScope(DataFlow::Node node) { any() }
}
import Stage<Stage1Input>
private module Stage1 = Stage<Stage1Input>;
cached
private module Cached {
cached
predicate rhs(TApiNode nd, DataFlow::Node rhs) { Stage1::rhs(nd, rhs) }
cached
predicate use(TApiNode nd, DataFlow::Node ref) { Stage1::use(nd, ref) }
cached
DataFlow::SourceNode trackUseNode(DataFlow::SourceNode nd) {
result = Stage1::trackUseNode(nd)
}
cached
DataFlow::SourceNode trackDefNode(DataFlow::Node nd) { result = Stage1::trackDefNode(nd) }
cached
predicate edge(TApiNode pred, Label::ApiLabel lbl, TApiNode succ) {
Stage1::edge(pred, lbl, succ)
}
cached
DataFlow::InvokeNode getAPromisifiedInvocation(TApiNode callee, int bound, TApiNode succ) {
result = Stage1::getAPromisifiedInvocation(callee, bound, succ)
}
}
import Cached
/**
* Holds if there is an edge from `pred` to `succ` in the API graph.