hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-05 21:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Swift: Model getVaList, correct NSLogv sink for swift/cleartext-logging.

Browse Source
This commit is contained in:
Geoffrey White
2023-08-15 13:23:19 +01:00
parent f5d776571b
commit b4595d8b92
4 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
swift/ql/lib/codeql/swift/frameworks/StandardLibrary/CInterop.qll Normal file
View File

@@ -0,0 +1,12 @@
/**
* Provides models for Swift "C Interoperability" functions.
*/
import swift
private import codeql.swift.dataflow.ExternalFlow
private class CInteropSummaries extends SummaryModelCsv {
override predicate row(string row) {
row = ";;false;getVaList(_:);;;Argument[0].ArrayElement;ReturnValue;value"
}
}

1
swift/ql/lib/codeql/swift/frameworks/StandardLibrary/StandardLibrary.qll
View File

@@ -3,6 +3,7 @@
*/
private import Array
private import CInterop
private import Collection
private import CustomUrlSchemes
private import Data

2
swift/ql/lib/codeql/swift/security/CleartextLoggingExtensions.qll
View File

@@ -94,7 +94,7 @@ private class LoggingSinks extends SinkModelCsv {
";;false;NSLog(_:_:);;;Argument[0];log-injection",
";;false;NSLog(_:_:);;;Argument[1].ArrayElement;log-injection",
";;false;NSLogv(_:_:);;;Argument[0];log-injection",
";;false;NSLogv(_:_:);;;Argument[1].ArrayElement;log-injection",
";;false;NSLogv(_:_:);;;Argument[1];log-injection",
";;false;vfprintf(_:_:_:);;;Agument[1..2];log-injection",
";Logger;true;log(_:);;;Argument[0];log-injection",
";Logger;true;log(level:_:);;;Argument[1];log-injection",

4
swift/ql/test/query-tests/Security/CWE-312/cleartextLoggingTest.swift
View File

@@ -96,8 +96,8 @@ func test1(password: String, passwordHash : String, passphrase: String, pass_phr
NSLog("%@", password as! CVarArg) // $ MISSING: hasCleartextLogging=96
NSLog("%@ %@", "" as! CVarArg, password as! CVarArg) // $ MISSING: hasCleartextLogging=97
NSLog("\(password)") // $ hasCleartextLogging=98
NSLogv("%@", getVaList([password as! CVarArg])) // $ MISSING: hasCleartextLogging=99
NSLogv("%@ %@", getVaList(["" as! CVarArg, password as! CVarArg])) // $ MISSING: hasCleartextLogging=100
NSLogv("%@", getVaList([password as! CVarArg])) // $ hasCleartextLogging=99
NSLogv("%@ %@", getVaList(["" as! CVarArg, password as! CVarArg])) // $ hasCleartextLogging=100
NSLog(passwordHash) // SAfe
NSLogv("%@", getVaList([passwordHash as! CVarArg])) // Safe